linux-kernel - [PATCH 2/2] ACPI: EC: Revert "ACPI / EC: Enable event freeze mode..." to fix a regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <c649e0a8ced621d0577d48a2b400f1a21a3a20ee.1499828705.git.lv.zheng@intel.com>
Date:   Wed, 12 Jul 2017 11:09:17 +0800
From:   Lv Zheng <lv.zheng@...el.com>
To:     "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Len Brown <len.brown@...el.com>
Cc:     Lv Zheng <lv.zheng@...el.com>, Lv Zheng <zetalog@...il.com>,
        linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
        "Stable # 4 . 9+" <stable@...r.kernel.org>
Subject: [PATCH 2/2] ACPI: EC: Revert "ACPI / EC: Enable event freeze mode..." to fix a regression

On Lenovo ThinkPad X1 Carbon - the 5th Generation, enabling an earlier EC
event freezing timing causes acpitz-virtual-0 to report a stucked 48C
temparature. And with EC firmware revisioned as 1.14, without reverting
back to old EC event freezing timing, the fan still blows up after a system
resume (see comment 168 on link #1).

This reverts the culprit change so that the regression can be fixed without
upgrading the EC firmware.

Fixes: d30283057ecd ("ACPI / EC: Enable event freeze mode to improve event handling")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=191181 [#1]
Tested-by: Damjan Georgievski <gdamjan@...il.com>
Signed-off-by: Lv Zheng <lv.zheng@...el.com>
Cc: Stable <stable@...r.kernel.org> # 4.9+
---
 drivers/acpi/ec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index 05e4eb5..ddb01e9 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -147,7 +147,7 @@ static unsigned int ec_storm_threshold  __read_mostly = 8;
 module_param(ec_storm_threshold, uint, 0644);
 MODULE_PARM_DESC(ec_storm_threshold, "Maxim false GPE numbers not considered as GPE storm");
 
-static bool ec_freeze_events __read_mostly = true;
+static bool ec_freeze_events __read_mostly = false;
 module_param(ec_freeze_events, bool, 0644);
 MODULE_PARM_DESC(ec_freeze_events, "Disabling event handling during suspend/resume");
 
-- 
2.7.4