linux-kernel - Re: [PATCH] printk: modify console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vfr5hEnjZWkQ4f2C7MB41Kw8-7q1mLgN=cNN7fOC7=BVQ@mail.gmail.com>
Date:   Sat, 15 Jul 2017 15:36:53 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Pierre Kuo <vichy.kuo@...il.com>
Cc:     Petr Mladek <pmladek@...e.com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Joe Perches <joe@...ches.com>
Subject: Re: [PATCH] printk: modify console_unlock with printk-safe macros

On Sat, Jul 15, 2017 at 1:36 PM, Pierre Kuo <vichy.kuo@...il.com> wrote:
> In commit de6fcbdb68b2 ("printk: convert the rest to printk-safe"), we
> create 4 helper macros to make printk-safe usage easier.
> Here we modify some part of console_unlock with above marcros.

>         raw_spin_lock(&logbuf_lock);

...and now we have "orphaned" call to lock.

> -       raw_spin_unlock(&logbuf_lock);

> +       logbuf_unlock_irqrestore(flags);

Personally I can't say this makes things clearer.

-- 
With Best Regards,
Andy Shevchenko