linux-kernel - Re: [PATCH 3/3] fat: fix quoted string splits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 16 Jul 2017 08:06:48 -0700
From:   Joe Perches <joe@...ches.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Carlos Palminha <CARLOS.PALMINHA@...opsys.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
        Alexander Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH 3/3] fat: fix quoted string splits

On Sun, 2017-07-16 at 16:46 +0300, Andy Shevchenko wrote:
> On Sat, Jul 15, 2017 at 7:18 AM, Joe Perches <joe@...ches.com> wrote:
> > On Sat, 2017-07-15 at 04:20 +0300, Andy Shevchenko wrote:
> > > On Sat, Jul 15, 2017 at 2:05 AM, Carlos Palminha
> > > <CARLOS.PALMINHA@...opsys.com> wrote:
> > > > corrects quoted string split across lines, based on checkpatch.
> > > 
> > > At some point you may switch
> > > 
> > > fat_msg(sb, KERN_ERR, ...)
> > > 
> > > to
> > > 
> > > fat_fs_error(sb, ...)
> > 
> > The output would be different.
> 
> As much as it adds 'error, ' at the beginning of message. I can't
> consider this a bad idea.

Adding "error" to KERN_ERR output is unnecessary
and if really desired, should be done by dmesg
or equivalent.