linux-kernel - Re: [PATCH 3/3] fat: fix quoted string splits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VcQgoM3OSN3sYBY3jsxKOm5jLrMZ4ET9bEO4sa3dXjyLA@mail.gmail.com>
Date:   Sun, 16 Jul 2017 18:30:34 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Carlos Palminha <CARLOS.PALMINHA@...opsys.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
        Alexander Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH 3/3] fat: fix quoted string splits

On Sun, Jul 16, 2017 at 6:06 PM, Joe Perches <joe@...ches.com> wrote:
> On Sun, 2017-07-16 at 16:46 +0300, Andy Shevchenko wrote:
>> On Sat, Jul 15, 2017 at 7:18 AM, Joe Perches <joe@...ches.com> wrote:

>> As much as it adds 'error, ' at the beginning of message. I can't
>> consider this a bad idea.
>
> Adding "error" to KERN_ERR output is unnecessary
> and if really desired, should be done by dmesg
> or equivalent.

Shouldn't be fixed in the function itself (__fat_fs_error())?

Anyway, this discussion is obviously for a separate change. The
original patch looks okay.

-- 
With Best Regards,
Andy Shevchenko