linux-kernel - Re: [PATCH 08/20] thread: move thread bits accessors to separated file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20170717155147.7s3qi2uduiz5ozon@yury-thinkpad>
Date:   Mon, 17 Jul 2017 18:51:47 +0300
From:   Yury Norov <ynorov@...iumnetworks.com>
To:     Andreas Schwab <schwab@...e.de>
Cc:     Catalin Marinas <catalin.marinas@....com>,
        Arnd Bergmann <arnd@...db.de>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org, Adam Borowski <kilobyte@...band.pl>,
        Andrew Pinski <pinskia@...il.com>,
        Bamvor Zhangjian <bamvor.zhangjian@...wei.com>,
        Chris Metcalf <cmetcalf@...hip.com>,
        Chris Metcalf <cmetcalf@...lanox.com>,
        Florian Weimer <fweimer@...hat.com>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        James Hogan <james.hogan@...tec.com>,
        James Morse <james.morse@....com>,
        Joseph Myers <joseph@...esourcery.com>,
        Maxim Kuvyrkov <maxim.kuvyrkov@...aro.org>,
        Nathan_Lynch@...tor.com, Prasun.Kapoor@...iumnetworks.com,
        Ramana Radhakrishnan <ramana.gcc@...glemail.com>,
        Steve Ellcey <sellcey@...iumnetworks.com>,
        Alexander Graf <agraf@...e.de>,
        Mark Brown <broonie@...nel.org>,
        christoph.muellner@...obroma-systems.com, davem@...emloft.net,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Alexey Klimov <klimov.linux@...il.com>, linyongting@...wei.com,
        manuel.montezelo@...il.com, philipp.tomsich@...obroma-systems.com,
        schwidefsky@...ibm.com, szabolcs.nagy@....com,
        zhouchengming1@...wei.com
Subject: Re: [PATCH 08/20] thread: move thread bits accessors to separated
 file

On Mon, Jul 17, 2017 at 04:57:02PM +0200, Andreas Schwab wrote:
> On Jun 19 2017, Yury Norov <ynorov@...iumnetworks.com> wrote:
> 
> > diff --git a/include/linux/thread_bits.h b/include/linux/thread_bits.h
> > new file mode 100644
> > index 000000000000..87354331bc7b
> > --- /dev/null
> > +++ b/include/linux/thread_bits.h
> > @@ -0,0 +1,63 @@
> > +/* thread_bits.h: common low-level thread bits accessors */
> > +
> > +#ifndef _LINUX_THREAD_BITS_H
> > +#define _LINUX_THREAD_BITS_H
> > +
> > +#ifndef __ASSEMBLY__
> > +
> > +#include <linux/bitops.h>
> > +#include <asm/thread_info.h>
> > +
> > +#ifdef CONFIG_THREAD_INFO_IN_TASK
> > +/*
> > + * For CONFIG_THREAD_INFO_IN_TASK kernels we need <asm/current.h> for the
> > + * definition of current, but for !CONFIG_THREAD_INFO_IN_TASK kernels,
> > + * including <asm/current.h> can cause a circular dependency on some platforms.
> > + */
> > +#include <asm/current.h>
> > +#define current_thread_info() ((struct thread_info *)current)
> > +#endif
> 
> This is duplicate.
> 
> > diff --git a/include/linux/thread_info.h b/include/linux/thread_info.h
> > index d7d3ea637dd0..c40a89357329 100644
> > --- a/include/linux/thread_info.h
> > +++ b/include/linux/thread_info.h
> > @@ -7,9 +7,21 @@
> >  #ifndef _LINUX_THREAD_INFO_H
> >  #define _LINUX_THREAD_INFO_H
> >  
> > +/*
> > + * For per-arch arch_within_stack_frames() implementations, defined in
> > + * asm/thread_info.h.
> > + */
> > +enum {
> > +	BAD_STACK = -1,
> > +	NOT_STACK = 0,
> > +	GOOD_FRAME,
> > +	GOOD_STACK,
> > +};
> > +
> 
> That should be kept after the includes.

Thanks, will fix.