linux-kernel - Re: [PATCH][next] ubifs: fix uninitialized error variable err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 17 Jul 2017 18:03:28 +0200
From:   Richard Weinberger <richard@....at>
To:     Colin King <colin.king@...onical.com>,
        Artem Bityutskiy <dedekind1@...il.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        linux-mtd@...ts.infradead.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        hyc.lee@...il.com, Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [PATCH][next] ubifs: fix uninitialized error variable err

Colin,

Am 17.07.2017 um 18:00 schrieb Colin King:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Variable err is not initialized and so the check to see if it is
> non-zero is basically checking a random garbage value. Fix this
> by initializing err to zero.
> 
> Detected by CoverityScan, CID#1451370 ("Uninitialized variable")
> 
> Fixes: 781f675e2d7e ("ubifs: Fix unlink code wrt. double hash lookups")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Thanks, geert already pointed out that I've merged a bad patch.
I managed to merge the patch without the issues fixed that Hyunchul Lee
identified. ;-(

Thanks,
//richard