linux-kernel - Re: [PATCH 2/3] mfd: syscon: atmel-smc: add helper to retrieve register layout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170718091238.wweaobzccdlgv5dh@dell>
Date:   Tue, 18 Jul 2017 10:12:38 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Ludovic Desroches <ludovic.desroches@...rochip.com>
Cc:     devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
        nicolas.ferre@...rochip.com, alexandre.belloni@...e-electrons.com,
        boris.brezillon@...e-electrons.com, computersforpeace@...il.com
Subject: Re: [PATCH 2/3] mfd: syscon: atmel-smc: add helper to retrieve
 register layout

On Tue, 18 Jul 2017, Lee Jones wrote:

> On Tue, 11 Jul 2017, Ludovic Desroches wrote:
> 
> > For HSMC controller, the register layout depends on the device i.e. the
> > offset of setup, pulse, cycle, mode and timings registers is not the
> > same. An helper is added to provide the correct register layout.
> > 
> > Fixes: fe9d7cb22ef3 ("mfd: syscon: atmel-smc: Add new helpers to ease
> > SMC regs manipulation")
> > Suggested-by: Boris Brezillon <boris.brezillon@...e-electrons.com>
> > Signed-off-by: Ludovic Desroches <ludovic.desroches@...rochip.com>
> > ---
> >  drivers/memory/atmel-ebi.c               | 13 +++++--
> >  drivers/mfd/atmel-smc.c                  | 67 +++++++++++++++++++++++++-------
> >  drivers/mtd/nand/atmel/nand-controller.c | 10 +++--
> >  include/linux/mfd/syscon/atmel-smc.h     | 32 ++++++++++-----
> >  4 files changed, 92 insertions(+), 30 deletions(-)
> 
> Applied, thanks.

Apologies, it looks like this needs 2 more Acks before I can even
consider taking it.

Unapplied.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog