linux-kernel - Re: [PATCH 2/3] mfd: syscon: atmel-smc: add helper to retrieve register layout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02a0c390-610c-d38b-e6a3-f04120c6fbb3@microchip.com>
Date:   Tue, 18 Jul 2017 11:23:43 +0200
From:   Nicolas Ferre <nicolas.ferre@...rochip.com>
To:     Lee Jones <lee.jones@...aro.org>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>
CC:     <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <alexandre.belloni@...e-electrons.com>,
        <boris.brezillon@...e-electrons.com>, <computersforpeace@...il.com>
Subject: Re: [PATCH 2/3] mfd: syscon: atmel-smc: add helper to retrieve
 register layout

On 18/07/2017 at 11:12, Lee Jones wrote:
> On Tue, 18 Jul 2017, Lee Jones wrote:
> 
>> On Tue, 11 Jul 2017, Ludovic Desroches wrote:
>>
>>> For HSMC controller, the register layout depends on the device i.e. the
>>> offset of setup, pulse, cycle, mode and timings registers is not the
>>> same. An helper is added to provide the correct register layout.
>>>
>>> Fixes: fe9d7cb22ef3 ("mfd: syscon: atmel-smc: Add new helpers to ease
>>> SMC regs manipulation")
>>> Suggested-by: Boris Brezillon <boris.brezillon@...e-electrons.com>
>>> Signed-off-by: Ludovic Desroches <ludovic.desroches@...rochip.com>
>>> ---
>>>  drivers/memory/atmel-ebi.c               | 13 +++++--
>>>  drivers/mfd/atmel-smc.c                  | 67 +++++++++++++++++++++++++-------
>>>  drivers/mtd/nand/atmel/nand-controller.c | 10 +++--
>>>  include/linux/mfd/syscon/atmel-smc.h     | 32 ++++++++++-----
>>>  4 files changed, 92 insertions(+), 30 deletions(-)
>>
>> Applied, thanks.
> 
> Apologies, it looks like this needs 2 more Acks before I can even
> consider taking it.
> 
> Unapplied.

If mine is missing, here it is:

For the whole series:
Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

And I think that Alexandre seemed okay by discussing the path those
patches should take...


Thanks, bye,
-- 
Nicolas Ferre