linux-kernel - Re: [RFC PATCH v2] Bluetooth: btusb: Fix memory leak in play

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1500370901.502.6.camel@suse.com>
Date:   Tue, 18 Jul 2017 11:41:41 +0200
From:   Oliver Neukum <oneukum@...e.com>
To:     jeffy <jeffy.chen@...k-chips.com>,
        Marcel Holtmann <marcel@...tmann.org>
Cc:     briannorris@...omium.org, dianders@...omium.org,
        Johan Hedberg <johan.hedberg@...il.com>,
        xiyou.wangcong@...il.com,
        "Gustavo F. Padovan" <gustavo@...ovan.org>,
        linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v2] Bluetooth: btusb: Fix memory leak in
 play_deferred

Am Dienstag, den 18.07.2017, 17:36 +0800 schrieb jeffy:
> Hi Oliver,
> 
> On 07/18/2017 04:41 PM, Oliver Neukum wrote:
> > 
> > Am Dienstag, den 18.07.2017, 16:08 +0800 schrieb jeffy:
> > > 
> > > > 
> > > > I am afraid not. We cannot silently drop one part of a transmission.
> > > > I am afraid that the correct algorithm, if we encounter an error at
> > > > that stage, is to abort the operation and report an error.
> > > > 
> > > so i should break the loop when error happens right?
> > 
> > Yes
> ok, i'll do that.
> > 
> > 
> > > 
> > > 
> > > and i uploaded 2 version of patches, which one do you prefer to go on?
> > 
> > Where to?
> https://patchwork.kernel.org/patch/9847037
> and
> https://patchwork.kernel.org/patch/9846617

I think that as soon as one URB fails, you should not even try
to submit any other deferred URBs. You are taking one out from
the middle of a sequence. That cannot be right.

	Regards
		Oliver