linux-kernel - Re: [PATCH 2/2] Revert "ASoC: ux500: drop platform DAI assignments"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Jul 2017 12:36:29 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     Johan Hovold <johan@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        alsa-devel@...a-project.org,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        linux-kernel@...r.kernel.org, stable <stable@...r.kernel.org>
Subject: Re: [PATCH 2/2] Revert "ASoC: ux500: drop platform DAI assignments"

On Tue, Jul 18, 2017 at 11:06:55AM +0100, Mark Brown wrote:
> On Tue, Jul 18, 2017 at 10:21:18AM +0200, Johan Hovold wrote:
> > On Mon, Jul 17, 2017 at 03:51:27PM +0100, Mark Brown wrote:
> 
> > > Please submit patches using subject lines reflecting the style for the
> > > subsystem.  This makes it easier for people to identify relevant
> > > patches.  Look at what existing commits in the area you're changing are
> > > doing and make sure your subject lines visually resemble what they're
> > > doing.
> 
> > I try to, but reverts are special as the default commit summary tend to
> > already contain the subsystem prefix and some maintainers find that
> > sufficient (or even preferred as this also makes reverts stand out more
> > clearly).
> 
> Reverts shouldn't be special - they're just regular patches and should
> have sensible changelogs like any others.

Stating that you're reverting a commit and which commit that is is in
the summary is arguable sensible (of course, you still also need further
details in the commit message body itself describing why it was needed).

Check the logs and you'll see that we have a ton of "Revert <reverted
commit summary>" for various subsystems. In fact, it seems to be by far
the most common summary for direct reverts.

But again, now I know your preference.

Johan