linux-kernel - Re: [PATCH] dmaengine: ioat: constify pci_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170718160232.GU3053@localhost>
Date:   Tue, 18 Jul 2017 21:32:33 +0530
From:   Vinod Koul <vinod.koul@...el.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     dan.j.williams@...el.com, dave.jiang@...el.com,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: ioat: constify pci_device_id.

On Mon, Jul 17, 2017 at 09:39:00PM +0530, Arvind Yadav wrote:
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>   12582	   3056	     16	  15654	   3d26	drivers/dma/ioat/init.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>   14773	    865	     16	  15654	   3d26	drivers/dma/ioat/init.o

Applied, thanks

-- 
~Vinod