linux-kernel - Re: [PATCH v2 1/7] ALSA: als100: fix format string overflow warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hy3rlag72.wl-tiwai@suse.de>
Date:   Tue, 18 Jul 2017 18:00:01 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Arnd Bergmann" <arnd@...db.de>
Cc:     "Jaroslav Kysela" <perex@...ex.cz>, <alsa-devel@...a-project.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/7] ALSA: als100: fix format string overflow warning

On Tue, 18 Jul 2017 13:48:04 +0200,
Arnd Bergmann wrote:
> 
> The compiler sees that the format string might overflow for the longname:
> 
> sound/isa/als100.c: In function 'snd_als100_pnp_detect':
> sound/isa/als100.c:225:27: error: ', dma ' directive writing 6 bytes into a region of size between 0 and 64 [-Werror=format-overflow=]
>    sprintf(card->longname, "%s, %s at 0x%lx, irq %d, dma %d",
>                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sound/isa/als100.c:225:3: note: 'sprintf' output between 24 and 113 bytes into a destination of size 80
>    sprintf(card->longname, "%s, %s at 0x%lx, irq %d, dma %d",
> 
> Open-coding "shortname" here gets us below the limit, and using
> snprintf() is a good idea too.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks, applied all 7 patches now to for-next branch.


Takashi