linux-kernel - Re: [PATCH] netvsc: Remove redundant use of ipv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <930440229.36662246.1500486483200.JavaMail.zimbra@redhat.com>
Date:   Wed, 19 Jul 2017 13:48:03 -0400 (EDT)
From:   Mohammed Gamal <mgamal@...hat.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     kys@...rosoft.com, haiyangz@...rosoft.com, sthemmin@...rosoft.com,
        otubo@...hat.com, linux-kernel@...r.kernel.org,
        devel@...uxdriverproject.org, vkuznets@...hat.com
Subject: Re: [PATCH] netvsc: Remove redundant use of ipv6_hdr()



----- Original Message -----
> On Wed, 19 Jul 2017 15:19:28 +0200
> Mohammed Gamal <mgamal@...hat.com> wrote:
> 
> > This condition already uses an object of type ipv6hdr in the line above.
> > Use the object directly instead of calling ipv6_hdr
> > 
> > Signed-off-by: Mohammed Gamal <mgamal@...hat.com>
> > ---
> >  drivers/net/hyperv/netvsc_drv.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/hyperv/netvsc_drv.c
> > b/drivers/net/hyperv/netvsc_drv.c
> > index 63c98bb..06d591c 100644
> > --- a/drivers/net/hyperv/netvsc_drv.c
> > +++ b/drivers/net/hyperv/netvsc_drv.c
> > @@ -339,7 +339,7 @@ static u32 net_checksum_info(struct sk_buff *skb)
> >  
> >  		if (ip6->nexthdr == IPPROTO_TCP)
> >  			return TRANSPORT_INFO_IPV6_TCP;
> > -		else if (ipv6_hdr(skb)->nexthdr == IPPROTO_UDP)
> > +		else if (ip6->nexthdr == IPPROTO_UDP)
> >  			return TRANSPORT_INFO_IPV6_UDP;
> >  	}
> >  
> 
> Patch looks fine.
> Network patches go through netdev@...r.kernel.org not linux driver mailing
> list.
> I will add it to my next patch of patches that are going to netdev for
> net-next.
> 
Thanks for the heads up. Will take that into consideration next time.

It's worth pointing out that MAINTAINERS points that files under 
drivers/net/hyperv are to be sent to devel@...uxdriverproject.org.
Perhaps that should be updated.