linux-kernel - Re: [PATCH] soc: Convert to using %pOF instead of full

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170719060153.GD6246@kozik-book>
Date:   Wed, 19 Jul 2017 08:01:53 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Rob Herring <robh@...nel.org>
Cc:     arm@...nel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, Scott Wood <oss@...error.net>,
        Qiang Zhao <qiang.zhao@....com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Simon Horman <horms@...ge.net.au>,
        Magnus Damm <magnus.damm@...il.com>,
        Kukjin Kim <kgene@...nel.org>,
        Javier Martinez Canillas <javier@....samsung.com>,
        linuxppc-dev@...ts.ozlabs.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        linux-renesas-soc@...r.kernel.org,
        linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH] soc: Convert to using %pOF instead of full_name

On Tue, Jul 18, 2017 at 04:43:29PM -0500, Rob Herring wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
> 
> Signed-off-by: Rob Herring <robh@...nel.org>
> Cc: Scott Wood <oss@...error.net>
> Cc: Qiang Zhao <qiang.zhao@....com>
> Cc: Matthias Brugger <matthias.bgg@...il.com>
> Cc: Simon Horman <horms@...ge.net.au>
> Cc: Magnus Damm <magnus.damm@...il.com>
> Cc: Kukjin Kim <kgene@...nel.org>
> Cc: Krzysztof Kozlowski <krzk@...nel.org>
> Cc: Javier Martinez Canillas <javier@....samsung.com>
> Cc: linuxppc-dev@...ts.ozlabs.org
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-mediatek@...ts.infradead.org
> Cc: linux-renesas-soc@...r.kernel.org
> Cc: linux-samsung-soc@...r.kernel.org
> ---
>  drivers/soc/fsl/qbman/bman_ccsr.c    | 10 +++++-----
>  drivers/soc/fsl/qbman/bman_portal.c  |  8 +++-----
>  drivers/soc/fsl/qbman/qman_ccsr.c    | 12 ++++++------
>  drivers/soc/fsl/qbman/qman_portal.c  | 11 ++++-------
>  drivers/soc/fsl/qe/gpio.c            |  4 ++--
>  drivers/soc/mediatek/mtk-pmic-wrap.c |  4 ++--
>  drivers/soc/renesas/rcar-rst.c       |  4 ++--
>  drivers/soc/renesas/rcar-sysc.c      |  6 +++---
>  drivers/soc/samsung/pm_domains.c     |  8 ++++----
>  9 files changed, 31 insertions(+), 36 deletions(-)
> 

(...)

> diff --git a/drivers/soc/samsung/pm_domains.c b/drivers/soc/samsung/pm_domains.c
> index a6a5d807cc2b..c630eba32066 100644
> --- a/drivers/soc/samsung/pm_domains.c
> +++ b/drivers/soc/samsung/pm_domains.c
> @@ -237,11 +237,11 @@ static __init int exynos4_pm_init_power_domain(void)
>  			continue;
> 
>  		if (of_genpd_add_subdomain(&parent, &child))
> -			pr_warn("%s failed to add subdomain: %s\n",
> -				parent.np->full_name, child.np->full_name);
> +			pr_warn("%pOF failed to add subdomain: %pOF\n",
> +				parent.np, child.np);
>  		else
> -			pr_info("%s has as child subdomain: %s.\n",
> -				parent.np->full_name, child.np->full_name);
> +			pr_info("%pOF has as child subdomain: %pOF.\n",
> +				parent.np, child.np);
>  	}
> 
>  	return 0;

I guess this will go through arm-soc?

For Samsung, looks good:
Acked-by: Krzysztof Kozlowski <krzk@...nel.org>

Best regards,
Krzysztof