linux-kernel - Re: [PATCH v2 1/1] xen/blkfront: always allocate grants first from per-queue persistent grants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <146ea895-9576-5899-28b7-52b145ffe82c@oracle.com>
Date:   Wed, 19 Jul 2017 15:49:55 +0800
From:   Dongli Zhang <dongli.zhang@...cle.com>
To:     Roger Pau Monné <roger.pau@...rix.com>,
        konrad.wilk@...cle.com
Cc:     xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org,
        boris.ostrovsky@...cle.com, jgross@...e.com
Subject: Re: [PATCH v2 1/1] xen/blkfront: always allocate grants first from
 per-queue persistent grants

Hi Konrad,

In addition to Junxiao's patch on xen-blkfront, would you please help merge this
to mainline as well?

Thank you very much!

Dongli Zhang

On 06/28/2017 11:34 PM, Roger Pau Monné wrote:
> On Wed, Jun 28, 2017 at 08:57:28PM +0800, Dongli Zhang wrote:
>> This patch partially reverts 3df0e50 ("xen/blkfront: pseudo support for
>> multi hardware queues/rings"). The xen-blkfront queue/ring might hang due
>> to grants allocation failure in the situation when gnttab_free_head is
>> almost empty while many persistent grants are reserved for this queue/ring.
>>
>> As persistent grants management was per-queue since 73716df ("xen/blkfront:
>> make persistent grants pool per-queue"), we should always allocate from
>> persistent grants first.
>>
>> Signed-off-by: Dongli Zhang <dongli.zhang@...cle.com>
> 
> Acked-by: Roger Pau Monné <roger.pau@...rix.com>
> 
> Thanks.
>