linux-kernel - Re: [PATCH v2 1/1] xen/blkfront: always allocate grants first from per-queue persistent grants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170628153410.replhtna2tpaxbrw@dhcp-3-128.uk.xensource.com>
Date:   Wed, 28 Jun 2017 16:34:10 +0100
From:   Roger Pau Monné <roger.pau@...rix.com>
To:     Dongli Zhang <dongli.zhang@...cle.com>
CC:     <xen-devel@...ts.xenproject.org>, <linux-kernel@...r.kernel.org>,
        <konrad.wilk@...cle.com>, <boris.ostrovsky@...cle.com>,
        <jgross@...e.com>
Subject: Re: [PATCH v2 1/1] xen/blkfront: always allocate grants first from
 per-queue persistent grants

On Wed, Jun 28, 2017 at 08:57:28PM +0800, Dongli Zhang wrote:
> This patch partially reverts 3df0e50 ("xen/blkfront: pseudo support for
> multi hardware queues/rings"). The xen-blkfront queue/ring might hang due
> to grants allocation failure in the situation when gnttab_free_head is
> almost empty while many persistent grants are reserved for this queue/ring.
> 
> As persistent grants management was per-queue since 73716df ("xen/blkfront:
> make persistent grants pool per-queue"), we should always allocate from
> persistent grants first.
> 
> Signed-off-by: Dongli Zhang <dongli.zhang@...cle.com>

Acked-by: Roger Pau Monné <roger.pau@...rix.com>

Thanks.