[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20170628174808.09a85fc6@thinkpad>
Date: Wed, 28 Jun 2017 17:48:08 +0200
From: Gerald Schaefer <gerald.schaefer@...ibm.com>
To: Joerg Roedel <joro@...tes.org>
Cc: iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
Suman Anna <s-anna@...com>, Joerg Roedel <jroedel@...e.de>
Subject: Re: [PATCH 1/3] iommu: Return ERR_PTR() values from device_group
call-backs
On Wed, 28 Jun 2017 14:00:56 +0200
Joerg Roedel <joro@...tes.org> wrote:
> From: Joerg Roedel <jroedel@...e.de>
>
> The generic device_group call-backs in iommu.c return NULL
> in case of error. Since they are getting ERR_PTR values from
> iommu_group_alloc(), just pass them up instead.
>
> Reported-by: Gerald Schaefer <gerald.schaefer@...ibm.com>
> Signed-off-by: Joerg Roedel <jroedel@...e.de>
> ---
Looks good,
Reviewed-by: Gerald Schaefer <gerald.schaefer@...ibm.com>
> drivers/iommu/iommu.c | 14 ++------------
> 1 file changed, 2 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index cf7ca7e..de09e1e 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -915,13 +915,7 @@ static int get_pci_alias_or_group(struct pci_dev *pdev, u16 alias, void *opaque)
> */
> struct iommu_group *generic_device_group(struct device *dev)
> {
> - struct iommu_group *group;
> -
> - group = iommu_group_alloc();
> - if (IS_ERR(group))
> - return NULL;
> -
> - return group;
> + return iommu_group_alloc();
> }
>
> /*
> @@ -988,11 +982,7 @@ struct iommu_group *pci_device_group(struct device *dev)
> return group;
>
> /* No shared group found, allocate new */
> - group = iommu_group_alloc();
> - if (IS_ERR(group))
> - return NULL;
> -
> - return group;
> + return iommu_group_alloc();
> }
>
> /**
Powered by blists - more mailing lists