[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <345ed003-6a6e-a876-fa91-cdc9fcc1cd89@ti.com>
Date: Wed, 28 Jun 2017 11:32:02 -0500
From: Suman Anna <s-anna@...com>
To: Joerg Roedel <joro@...tes.org>, <iommu@...ts.linux-foundation.org>
CC: <linux-kernel@...r.kernel.org>,
Gerald Schaefer <gerald.schaefer@...ibm.com>,
Joerg Roedel <jroedel@...e.de>
Subject: Re: [PATCH 2/3] iommu/omap: Return ERR_PTR in device_group call-back
On 06/28/2017 07:00 AM, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@...e.de>
>
> Make sure that the device_group callback returns an ERR_PTR
> instead of NULL.
>
> Signed-off-by: Joerg Roedel <jroedel@...e.de>
Thanks for the patch,
Acked-by: Suman Anna <s-anna@...com>
regards
Suman
> ---
> drivers/iommu/omap-iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
> index 95dfca3..641e035 100644
> --- a/drivers/iommu/omap-iommu.c
> +++ b/drivers/iommu/omap-iommu.c
> @@ -1309,7 +1309,7 @@ static void omap_iommu_remove_device(struct device *dev)
> static struct iommu_group *omap_iommu_device_group(struct device *dev)
> {
> struct omap_iommu_arch_data *arch_data = dev->archdata.iommu;
> - struct iommu_group *group = NULL;
> + struct iommu_group *group = ERR_PTR(-EINVAL);
>
> if (arch_data->iommu_dev)
> group = arch_data->iommu_dev->group;
>
Powered by blists - more mailing lists