linux-kernel - Re: [PATCH V2 net-next 20/21] net-next/hinic: Add ethtool and stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1500460074.25934.33.camel@perches.com>
Date:   Wed, 19 Jul 2017 03:27:54 -0700
From:   Joe Perches <joe@...ches.com>
To:     Aviad Krawczyk <aviad.krawczyk@...wei.com>, davem@...emloft.net
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        bc.y@...wei.com, victor.gissin@...wei.com, zhaochen6@...wei.com,
        tony.qu@...wei.com
Subject: Re: [PATCH V2 net-next 20/21] net-next/hinic: Add ethtool and stats

On Wed, 2017-07-19 at 17:19 +0800, Aviad Krawczyk wrote:
> Add ethtool operations and statistics operations.

series trivia:

> diff --git a/drivers/net/ethernet/huawei/hinic/hinic_main.c b/drivers/net/ethernet/huawei/hinic/hinic_main.c
[]
> @@ -67,6 +67,178 @@
[]
> +static int hinic_get_link_ksettings(struct net_device *netdev,
> +				    struct ethtool_link_ksettings
> +				    *link_ksettings)
> +{
[]
> +	err = hinic_port_get_cap(nic_dev, &port_cap);
> +	if (err) {
> +		dev_err(&netdev->dev, "Failed to get port capabilities\n");
> +		return err;
> +	}

it looks like a lot of these dev_<level> calls
should be converted to netdev_<level>

from:
		dev_err(&netdev->dev, ...);
to:
		netdev_err(netdev, ...);

etc...