linux-kernel - Re: [PATCH v3 1/3] of: overlay: add overlay unittest data for node names and symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+2VDvgK-N93rOYAJ=TSGDJeJfP_ba0jM2=suLZ6OBrtQ@mail.gmail.com>
Date:   Wed, 19 Jul 2017 08:39:07 -0500
From:   Rob Herring <robh+dt@...nel.org>
To:     Frank Rowand <frowand.list@...il.com>
Cc:     Pantelis Antoniou <pantelis.antoniou@...sulko.com>,
        Pantelis Antoniou <panto@...oniou-consulting.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/3] of: overlay: add overlay unittest data for node
 names and symbols

On Tue, Jul 18, 2017 at 10:52 PM,  <frowand.list@...il.com> wrote:
> From: Frank Rowand <frank.rowand@...y.com>
>
> Add nodes and properties to overlay_base and overlay dts files to
> test for
>    - incorrect existing node name detection when overlay node name
>      has a unit-address
>    - adding overlay __symbols__ properties to live tree when an
>      overlay is added to the live tree
>
> The following console messages will appear near the end of unittest
> until the code errors are corrected:
>
>    OF: Duplicate name in fairway-1, renamed to "ride@...#1"
>
>    ### dt-test ### FAIL of_unittest_overlay_high_level():2296 Adding overlay 'overlay_bad_symbol' failed
>
>    ### dt-test ### end of unittest - 190 passed, 1 failed
>
> Signed-off-by: Frank Rowand <frank.rowand@...y.com>
> ---

> diff --git a/drivers/of/unittest-data/overlay.dts b/drivers/of/unittest-data/overlay.dts
> index 6cd7e6a0c13e..81140adbe770 100644
> --- a/drivers/of/unittest-data/overlay.dts
> +++ b/drivers/of/unittest-data/overlay.dts
> @@ -25,7 +25,18 @@
>                         #size-cells = <1>;
>                         status = "ok";
>
> -                       ride@200 {
> +                       ride@100 {
> +
> +                               track@3 {

These need a reg property.

> +                                       incline_up = < 48 32 16 >;

Don't use '_'.

Build with W=2 to check dtc warnings.

Rob