linux-kernel - Re: [PATCH 7/7] x86: microcode: constify attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170720081207.GA18424@nazgul.tnic>
Date:   Thu, 20 Jul 2017 10:12:07 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
        x86@...nel.org, tony.luck@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/7] x86: microcode: constify attribute_group structures.

On Thu, Jul 20, 2017 at 12:51:45PM +0530, Arvind Yadav wrote:
> attribute_group are not supposed to change at runtime. All functions
> working with attribute_group provided by <linux/sysfs.h> work with
> const attribute_group. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>    3614	    545	   1560	   5719	   1657	x86/kernel/cpu/microcode/core.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>    3742	    417	   1560	   5719	   1657	x86/kernel/cpu/microcode/core.o

Again, what are those before/after sizes supposed to show?

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--