linux-kernel - Re: [PATCH 7/7] x86: microcode: constify attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27e82108-10c3-a411-d6ad-c399b603db82@gmail.com>
Date:   Thu, 20 Jul 2017 13:48:17 +0530
From:   Arvind Yadav <arvind.yadav.cs@...il.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
        x86@...nel.org, tony.luck@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/7] x86: microcode: constify attribute_group structures.

Hi,


On Thursday 20 July 2017 01:42 PM, Borislav Petkov wrote:
> On Thu, Jul 20, 2017 at 12:51:45PM +0530, Arvind Yadav wrote:
>> attribute_group are not supposed to change at runtime. All functions
>> working with attribute_group provided by <linux/sysfs.h> work with
>> const attribute_group. So mark the non-const structs as const.
>>
>> File size before:
>>     text	   data	    bss	    dec	    hex	filename
>>     3614	    545	   1560	   5719	   1657	x86/kernel/cpu/microcode/core.o
>>
>> File size After adding 'const':
>>     text	   data	    bss	    dec	    hex	filename
>>     3742	    417	   1560	   5719	   1657	x86/kernel/cpu/microcode/core.o
> Again, what are those before/after sizes supposed to show?
It's just show, how much bytes move from data segment to text segment.
~arvind