linux-kernel - Re: [PATCH 7/7] x86: microcode: constify attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170720082850.GB18424@nazgul.tnic>
Date:   Thu, 20 Jul 2017 10:28:50 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
        x86@...nel.org, tony.luck@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/7] x86: microcode: constify attribute_group structures.

On Thu, Jul 20, 2017 at 01:48:17PM +0530, Arvind Yadav wrote:
> It's just show, how much bytes move from data segment to text segment.
> ~arvind

     3614	    545	   1560	   5719	   1657	x86/kernel/cpu/microcode/core.o

3614 + 545 = 4159

     3742	    417	   1560	   5719	   1657	x86/kernel/cpu/microcode/core.o

3742 + 417 = 4159

3742 - 3614 = 128

So 128 bytes moved to text.

I fail to see how this is relevant. Your commit message contains not
really relevant info for such a simple change. Rather, it should just be
a one-liner:

"Constify attribute_group structs because they don't change at runtime."

That's it.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--