lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 20 Jul 2017 13:02:42 +0200 From: "Wolf Entwicklungen" <Marcus.Wolf@...f-Entwicklungen.de> To: "Colin King" <colin.king@...onical.com> Cc: "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>, "Marcus Wolf" <linux@...f-entwicklungen.de>, devel@...verdev.osuosl.org, kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 3/3][staging-next] staging: pi433: fix thread_run failure check Reviewed-by: Marcus Wolf <linux@...f-entwicklungen.de> Tested-by: Marcus Wolf <linux@...f-entwicklungen.de> Am Di, 18.07.2017, 15:04 schrieb Colin King: > From: Colin Ian King <colin.king@...onical.com> > > The check for thread_run failure is incorrect, use IS_ERR instead. > > Cleans up sparse error message: > "error: incompatible types for operation (<)" > > Fixes: 874bcba65f9a ("staging: pi433: New driver") > Signed-off-by: Colin Ian King <colin.king@...onical.com> > --- > drivers/staging/pi433/pi433_if.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c > index 95930a192de4..266e572ae66e 100644 > --- a/drivers/staging/pi433/pi433_if.c > +++ b/drivers/staging/pi433/pi433_if.c > @@ -1152,8 +1152,7 @@ static int pi433_probe(struct spi_device *spi) > device->tx_task_struct = kthread_run(pi433_tx_thread, > device, > "pi433_tx_task"); > - if (device->tx_task_struct < 0) > - { > + if (IS_ERR(device->tx_task_struct)) { > dev_dbg(device->dev, "start of send thread failed"); > goto send_thread_failed; > } > -- > 2.11.0 > > >
Powered by blists - more mailing lists