linux-kernel - Re: [PATCH v3 00/23] Qualcomm 8x16 Camera Subsystem driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 Jul 2017 10:39:07 +0300
From:   Todor Tomov <todor.tomov@...aro.org>
To:     Hans Verkuil <hverkuil@...all.nl>, mchehab@...nel.org,
        hans.verkuil@...co.com, javier@....samsung.com,
        s.nawrocki@...sung.com, sakari.ailus@....fi,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v3 00/23] Qualcomm 8x16 Camera Subsystem driver

Hello Hans,

On 19.07.2017 13:54, Hans Verkuil wrote:
> On 17/07/17 12:33, Todor Tomov wrote:
>> This patchset adds basic support for the Qualcomm Camera Subsystem found
>> on Qualcomm MSM8916 and APQ8016 processors.
>>
>> The driver implements V4L2, Media controller and V4L2 subdev interfaces.
>> Camera sensor using V4L2 subdev interface in the kernel is supported.
>>
>> The driver is implemented using as a reference the Qualcomm Camera
>> Subsystem driver for Android as found in Code Aurora [1].
>>
>> The driver is tested on Dragonboard 410C (APQ8016) with one and two
>> OV5645 camera sensors. media-ctl [2] and yavta [3] applications were
>> used for testing. Also Gstreamer 1.10.4 with v4l2src plugin is supported.
>>
>> More information is present in the document added by the third patch.
> 
> OK, so this looks pretty good. I have one comment for patch 12/23, and the
> dt-bindings need to be acked.
> 
> I suggest you make a v3.1 for patch 12/23 and then I'll wait for the binding
> ack. Once that's in (and there are no other comments) I will merge this.

Thank you for the review!
I'll update patch 12/23 and will send in the next version along with the rest
of the fixes from the review.

> 
> Regards,
> 
> 	Hans
> 

-- 
Best regards,
Todor Tomov