linux-kernel - Re: [PATCH v3 00/23] Qualcomm 8x16 Camera Subsystem driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 Jul 2017 10:50:23 +0300
From:   Todor Tomov <todor.tomov@...aro.org>
To:     Sakari Ailus <sakari.ailus@....fi>
Cc:     mchehab@...nel.org, hans.verkuil@...co.com, javier@....samsung.com,
        s.nawrocki@...sung.com, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v3 00/23] Qualcomm 8x16 Camera Subsystem driver

Hello Sakari,

Thank you for the review!

On 20.07.2017 18:25, Sakari Ailus wrote:
> Hi Todor,
> 
> On Mon, Jul 17, 2017 at 01:33:26PM +0300, Todor Tomov wrote:
>> This patchset adds basic support for the Qualcomm Camera Subsystem found
>> on Qualcomm MSM8916 and APQ8016 processors.
>>
>> The driver implements V4L2, Media controller and V4L2 subdev interfaces.
>> Camera sensor using V4L2 subdev interface in the kernel is supported.
>>
>> The driver is implemented using as a reference the Qualcomm Camera
>> Subsystem driver for Android as found in Code Aurora [1].
>>
>> The driver is tested on Dragonboard 410C (APQ8016) with one and two
>> OV5645 camera sensors. media-ctl [2] and yavta [3] applications were
>> used for testing. Also Gstreamer 1.10.4 with v4l2src plugin is supported.
>>
>> More information is present in the document added by the third patch.
> 
> After addressing the comments (please pay attention especially those
> affecting the user space API behaviour) you can add:
> 
> Acked-by: Sakari Ailus <sakari.ailus@...ux.intel.com>
> 
> Let me know if you have any further questions on the individual comments.
> 

I'll prepare updates based on your comments. I'll reply to individual
comments only if there is something to discuss, the others I'll fix
directly.

Also, we had a discussion with Rob Herring about the device tree
binding and he requested some more opinions. If you have something
to say about this, please do. You can see the context here:

https://lkml.org/lkml/2017/6/19/280
https://lkml.org/lkml/2017/6/29/311


-- 
Best regards,
Todor Tomov