linux-kernel - Re: [PATCH 058/102] phy: rockchip-pcie: explicitly request exclusive reset control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8d913686-5765-c808-772f-da389e991b71@rock-chips.com>
Date:   Sat, 22 Jul 2017 21:09:05 +0800
From:   Shawn Lin <shawn.lin@...k-chips.com>
To:     Philipp Zabel <p.zabel@...gutronix.de>
Cc:     linux-kernel@...r.kernel.org, shawn.lin@...k-chips.com,
        linux-rockchip@...ts.infradead.org,
        Heiko Stuebner <heiko@...ech.de>,
        Kishon Vijay Abraham I <kishon@...com>
Subject: Re: [PATCH 058/102] phy: rockchip-pcie: explicitly request exclusive
 reset control

Hi Philipp

On 2017/7/19 23:26, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Kishon Vijay Abraham I <kishon@...com>
> Cc: Heiko Stuebner <heiko@...ech.de>
> Cc: linux-rockchip@...ts.infradead.org
> Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de>
> ---
>  drivers/phy/rockchip/phy-rockchip-pcie.c | 2 +-

This driver is under reconstruction and would probably go via
pci tree later. So I would mention your change to the reconstruction
work if that's applied.

>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/rockchip/phy-rockchip-pcie.c b/drivers/phy/rockchip/phy-rockchip-pcie.c
> index 6904633cad687..258220b7f481c 100644
> --- a/drivers/phy/rockchip/phy-rockchip-pcie.c
> +++ b/drivers/phy/rockchip/phy-rockchip-pcie.c
> @@ -305,7 +305,7 @@ static int rockchip_pcie_phy_probe(struct platform_device *pdev)
>  	rk_phy->phy_data = (struct rockchip_pcie_data *)of_id->data;
>  	rk_phy->reg_base = grf;
>
> -	rk_phy->phy_rst = devm_reset_control_get(dev, "phy");
> +	rk_phy->phy_rst = devm_reset_control_get_exclusive(dev, "phy");
>  	if (IS_ERR(rk_phy->phy_rst)) {
>  		if (PTR_ERR(rk_phy->phy_rst) != -EPROBE_DEFER)
>  			dev_err(dev,
>


-- 
Best Regards
Shawn Lin