lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 22 Jul 2017 14:46:30 +0200 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: Pavel Shilovskiy <pshilov@...rosoft.com> Cc: Ben Hutchings <ben@...adent.org.uk>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Sachin Prabhu <sprabhu@...hat.com>, "stable@...r.kernel.org" <stable@...r.kernel.org> Subject: Re: [PATCH 3.18 36/68] Handle mismatched open calls On Wed, Jul 19, 2017 at 06:39:13PM +0000, Pavel Shilovskiy wrote: > 2017-07-14 9:43 Ben Hutchings <ben@...adent.org.uk>: > > On Fri, 2017-05-05 at 11:32 -0700, Greg Kroah-Hartman wrote: > > > 3.18-stable review patch. If anyone has any objections, please let me know. > > > > > > ------------------ > > > > > > From: Sachin Prabhu <sprabhu@...hat.com> > > > > > > commit 38bd49064a1ecb67baad33598e3d824448ab11ec upstream. > > [...] > > > --- a/fs/cifs/smb2ops.c > > > +++ b/fs/cifs/smb2ops.c > > > @@ -1461,6 +1461,8 @@ struct smb_version_operations smb21_oper > > > .clear_stats = smb2_clear_stats, > > > .print_stats = smb2_print_stats, > > > .is_oplock_break = smb2_is_valid_oplock_break, > > > + .handle_cancelled_mid = smb2_handle_cancelled_mid, > > > + .handle_cancelled_mid = smb2_handle_cancelled_mid, > > > .downgrade_oplock = smb2_downgrade_oplock, > > > .need_neg = smb2_need_neg, > > > .negotiate = smb2_negotiate, > > > @@ -1542,6 +1544,8 @@ struct smb_version_operations smb30_oper > > > .print_stats = smb2_print_stats, > > > .dump_share_caps = smb2_dump_share_caps, > > > .is_oplock_break = smb2_is_valid_oplock_break, > > > + .handle_cancelled_mid = smb2_handle_cancelled_mid, > > > + .handle_cancelled_mid = smb2_handle_cancelled_mid, > > > .downgrade_oplock = smb2_downgrade_oplock, > > > .need_neg = smb2_need_neg, > > > .negotiate = smb2_negotiate, > > [...] > > > > This doesn't look right. handle_cancelled_mid should be initialised once in each of the 3 smb_version_operations structures, shouldn't it? > > > > Ben. > > Yes, you are right. Thanks for pointing it out. > > Greg, I provided the patch to fix the above bug (see the attachment). > Could you please look at it and apply to the 3.18.x kernel if it is > suitable? Looks good, now queued up, thanks. greg k-h
Powered by blists - more mailing lists