linux-kernel - Re: [PATCHv4 3/4] dt-bindings: mfd: da9052: support TSI as ADC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b0d58a26-d0b4-a6ec-811a-159bbb8b44d1@roeck-us.net>
Date:   Sat, 22 Jul 2017 08:09:08 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Sebastian Reichel <sebastian.reichel@...labora.co.uk>,
        Lee Jones <lee.jones@...aro.org>
Cc:     Support Opensource <support.opensource@...semi.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Jean Delvare <jdelvare@...e.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        devicetree@...r.kernel.org, linux-hwmon@...r.kernel.org,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv4 3/4] dt-bindings: mfd: da9052: support TSI as ADC

On 07/17/2017 04:27 AM, Sebastian Reichel wrote:
> Hi Lee,
> 
> On Mon, Jul 17, 2017 at 11:49:45AM +0100, Lee Jones wrote:
>> On Fri, 30 Jun 2017, Sebastian Reichel wrote:
>>
>>> DA9052 allows using the touchscreen input pins as general purpose
>>> analogue input pin by wiring analogue inputs to X+, X-, Y+ and Y-
>>> and providing a reference voltage at TSIREF pin.
>>>
>>> Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.co.uk>
>>> ---
>>>   Documentation/devicetree/bindings/mfd/da9052-i2c.txt | 8 ++++++++
>>>   1 file changed, 8 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mfd/da9052-i2c.txt b/Documentation/devicetree/bindings/mfd/da9052-i2c.txt
>>> index 9554292dc6cb..57fa74e65664 100644
>>> --- a/Documentation/devicetree/bindings/mfd/da9052-i2c.txt
>>> +++ b/Documentation/devicetree/bindings/mfd/da9052-i2c.txt
>>> @@ -4,6 +4,14 @@ Required properties:
>>>   - compatible : Should be "dlg,da9052", "dlg,da9053-aa",
>>>   			 "dlg,da9053-ab", or "dlg,da9053-bb"
>>>   
>>> +Optional properties:
>>> +- dlg,tsi-as-adc : Boolean, if set the X+, X-, Y+, Y- touchscreen
>>> +                    input lines are used as general purpose analogue
>>> +					input.
>>> +- tsiref-supply: Phandle to the regulator, which provides the reference
>>> +                 voltage for the TSIREF pin. Must be provided when the
>>> +			     touchscreen pins are used for ADC purposes.
>>> +
>>
>> DT Ack please.
> 
> There is a v5 of this series, which has Acked-by from Rob already
> and got positive feedback from Guenter Roeck for the hwmon parts:
> 
> http://lkml.iu.edu/hypermail/linux/kernel/1707.0/00518.html
> 
> (if you received v4, v5 should also be in your INBOX)
> 

Yes, but you dropped all the Acks in v6. That is supposed to mean that there
was a substantial change to the patch, and that it needs to be re-reviewed.
For the hwmon patches, I ran a diff against v5 and noticed that there was no
change between v5 and v6, yet you dropped my Acks. Do you really expect us
to do all that work on your behalf ?

Sorry if I sound a bit annoyed. That is because I _am_ a bit annoyed.
Please keep in mind that you are taking our time.

Thanks,
Guenter