linux-kernel - Re: [PATCH 3/9] firmware: arm_scmi: add basic driver infrastructure for SCMI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd935dab-06b8-a91b-d393-cfc2f085c600@arm.com>
Date:   Mon, 24 Jul 2017 17:21:38 +0100
From:   Sudeep Holla <sudeep.holla@....com>
To:     Jassi Brar <jassisinghbrar@...il.com>
Cc:     Sudeep Holla <sudeep.holla@....com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Rob Herring <robh@...nel.org>,
        Alexey Klimov <alexey.klimov@....com>, Loc Ho <lho@....com>,
        Mark Rutland <mark.rutland@....com>,
        "arnd@...db.de" <arnd@...db.de>,
        Jassi Brar <jaswinder.singh@...aro.org>,
        Roy Franz <roy.franz@...ium.com>,
        Harb Abdulhamid <harba@...eaurora.org>,
        Matt Sealey <neko@...uhatsu.net>,
        ALKML <linux-arm-kernel@...ts.infradead.org>,
        DTML <devicetree@...r.kernel.org>, Nishanth Menon <nm@...com>
Subject: Re: [PATCH 3/9] firmware: arm_scmi: add basic driver infrastructure
 for SCMI



On 24/07/17 16:41, Jassi Brar wrote:
> On Mon, Jul 24, 2017 at 3:20 PM, Sudeep Holla <sudeep.holla@....com> wrote:
>>
>>
>> On 08/07/17 06:32, Jassi Brar wrote:
>>> Hi Roy, Matt, Nishant, Harb Abdulhamid, Loc,
>>>
>>> I have a gut feeling you guys were part of the SCMI spec committee. If
>>> so, could you please chime in?
>>>
>>
>> I take complete silence as no objection.
>>
> I take it as no self respecting developer/architect would stand by
> your FUBAR implementation of SCMI.
>

Wow really ? This is exactly how ACPI PCC works today IIUC.

> SCMI  calls
>     mbox_send_message(struct mbox_chan *chan, struct scmi_xfer *xfer);
> 
> whereas the API expects
>     mbox_send_message(struct mbox_chan *chan, struct controller_specific *xfer);
> 

That's not hard to change but you seem to have combined my ARM MHU
changes into this which is totally wrong and now I say also stupid after
mentioning the same thing so many times. Consider them independently and
try to understand.

> As the maintainer I have tried to explain it to you in a dozen ways.
> If you still can't see how it's broken, you can't be helped.
> 

Sorry but you wanted driver to explain initially. I posted them. But you
haven't answer my specific questions yet.

-- 
Regards,
Sudeep