linux-kernel - Re: [PATCH 07/11] mfd: Drop unnecessary static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170724192026.GF32425@amd>
Date:   Mon, 24 Jul 2017 21:20:26 +0200
From:   Pavel Machek <pavel@....cz>
To:     Julia Lawall <julia.lawall@...6.fr>
Cc:     Mark D Rustad <mrustad@...il.com>,
        Tony Lindgren <tony@...mide.com>, keescook@...omium.org,
        kernel-janitors@...r.kernel.org, Lee Jones <lee.jones@...aro.org>,
        linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 07/11] mfd: Drop unnecessary static

Hi!

> > > Drop static on a local variable, when the variable is initialized before
> > > any possible use.  Thus, the static has no benefit.

Actually... it has possible other benefit -- saving stack space. I've
used static for that purpose before. So ... careful with the
automation.

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)