linux-kernel - Re: [PATCH 07/11] mfd: Drop unnecessary static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jKAO+9VjPnPWNUk3jH6iZwCy9+NPgYEQ+LFUdJciLJx0g@mail.gmail.com>
Date:   Mon, 24 Jul 2017 15:27:07 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Pavel Machek <pavel@....cz>
Cc:     Julia Lawall <julia.lawall@...6.fr>,
        Mark D Rustad <mrustad@...il.com>,
        Tony Lindgren <tony@...mide.com>,
        kernel-janitors@...r.kernel.org, Lee Jones <lee.jones@...aro.org>,
        linux-omap@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 07/11] mfd: Drop unnecessary static

On Mon, Jul 24, 2017 at 12:20 PM, Pavel Machek <pavel@....cz> wrote:
> Hi!
>
>> > > Drop static on a local variable, when the variable is initialized before
>> > > any possible use.  Thus, the static has no benefit.
>
> Actually... it has possible other benefit -- saving stack space. I've
> used static for that purpose before. So ... careful with the
> automation.

This means any functions like this must not be thread safe, though...

-Kees

-- 
Kees Cook
Pixel Security