linux-kernel - Re: [PATCH -tip] [BUGFIX] kprobes/x86: Do not jump-optimize kprobes on irq entry code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170725104554.b58850228986eb94d56dcb0e@kernel.org>
Date:   Tue, 25 Jul 2017 10:45:54 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Ingo Molnar <mingo@...nel.org>,
        Francis Deslauriers <francis.deslauriers@...icios.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Ananth N Mavinakayanahalli <ananth@...ibm.com>,
        Anil S Keshavamurthy <anil.s.keshavamurthy@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -tip] [BUGFIX] kprobes/x86: Do not jump-optimize kprobes
 on irq entry code

On Tue, 25 Jul 2017 09:15:29 +0900
Masami Hiramatsu <mhiramat@...nel.org> wrote:

> > arch/x86/kernel/unwind_frame.c is only compiled when CONFIG_FRAME_POINTER
> > is enabled, but CONFIG_KPROBES does not depend on it.
> > 
> > Is unwind_frame.c really where in_entry_code() should be implemented, now
> > that its symbol becomes exposed to other compile units ?
> 
> At least kprobes needs it. (as far 
> It seems we can move it in arch/x86/entry/common.c or 
> somewhere in header. (arm has arch/arm/include/asm/traps.h for
> that purpose)

As far as I can see, that code is only for unwinder or kprobes,
and only arm/arm64 has similar code.

I've decided to make this fix kprobe/opt.c local, since this fix
is also needed for stable. I'll send v2 patch soon.

Thanks,

-- 
Masami Hiramatsu <mhiramat@...nel.org>