linux-kernel - Re: [PATCH -tip] [BUGFIX] kprobes/x86: Do not jump-optimize kprobes on irq entry code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 25 Jul 2017 12:29:00 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     kbuild-all@...org, Ingo Molnar <mingo@...nel.org>,
        Francis Deslauriers <francis.deslauriers@...icios.com>,
        mathieu.desnoyers@...icios.com,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Ananth N Mavinakayanahalli <ananth@...ibm.com>,
        Anil S Keshavamurthy <anil.s.keshavamurthy@...el.com>,
        "David S . Miller" <davem@...emloft.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -tip] [BUGFIX] kprobes/x86: Do not jump-optimize kprobes
 on irq entry code

Hi Masami,

[auto build test ERROR on tip/x86/core]
[also build test ERROR on v4.13-rc2 next-20170724]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Masami-Hiramatsu/kprobes-x86-Do-not-jump-optimize-kprobes-on-irq-entry-code/20170725-121438
config: i386-randconfig-x019-201730 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   arch/x86/kernel/unwind_frame.c: In function 'in_entry_code':
>> arch/x86/kernel/unwind_frame.c:95:14: error: '__irqentry_text_start' undeclared (first use in this function)
     if (addr >= __irqentry_text_start && addr < __irqentry_text_end)
                 ^~~~~~~~~~~~~~~~~~~~~
   arch/x86/kernel/unwind_frame.c:95:14: note: each undeclared identifier is reported only once for each function it appears in
>> arch/x86/kernel/unwind_frame.c:95:46: error: '__irqentry_text_end' undeclared (first use in this function)
     if (addr >= __irqentry_text_start && addr < __irqentry_text_end)
                                                 ^~~~~~~~~~~~~~~~~~~

vim +/__irqentry_text_start +95 arch/x86/kernel/unwind_frame.c

24d86f59 Josh Poimboeuf   2016-10-27   86  
6b4d2348 Masami Hiramatsu 2017-07-24   87  bool in_entry_code(unsigned long ip)
a8b7a923 Josh Poimboeuf   2017-04-12   88  {
a8b7a923 Josh Poimboeuf   2017-04-12   89  	char *addr = (char *)ip;
a8b7a923 Josh Poimboeuf   2017-04-12   90  
a8b7a923 Josh Poimboeuf   2017-04-12   91  	if (addr >= __entry_text_start && addr < __entry_text_end)
a8b7a923 Josh Poimboeuf   2017-04-12   92  		return true;
a8b7a923 Josh Poimboeuf   2017-04-12   93  
6b4d2348 Masami Hiramatsu 2017-07-24   94  #if defined(CONFIG_FUNCTION_GRAPH_TRACER) || defined(CONFIG_KASAN) || defined(CONFIG_KPROBES)
a8b7a923 Josh Poimboeuf   2017-04-12  @95  	if (addr >= __irqentry_text_start && addr < __irqentry_text_end)
a8b7a923 Josh Poimboeuf   2017-04-12   96  		return true;
a8b7a923 Josh Poimboeuf   2017-04-12   97  #endif
a8b7a923 Josh Poimboeuf   2017-04-12   98  
a8b7a923 Josh Poimboeuf   2017-04-12   99  	return false;
a8b7a923 Josh Poimboeuf   2017-04-12  100  }
a8b7a923 Josh Poimboeuf   2017-04-12  101  

:::::: The code at line 95 was first introduced by commit
:::::: a8b7a92318b6d7779f6d8e9aa6ba0e3de01a8943 x86/unwind: Silence entry-related warnings

:::::: TO: Josh Poimboeuf <jpoimboe@...hat.com>
:::::: CC: Ingo Molnar <mingo@...nel.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (30141 bytes)