linux-kernel - Re: [PATCH v4 3/7] phy: qcom-qmp: Fix phy pipe clock name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 26 Jul 2017 20:59:07 +0530
From:   Vivek Gautam <vivek.gautam@...eaurora.org>
To:     Varadarajan Narayanan <varada@...eaurora.org>, bhelgaas@...gle.com,
        robh+dt@...nel.org, mark.rutland@....com, svarbanov@...sol.com,
        kishon@...com, sboyd@...eaurora.org, fengguang.wu@...el.com,
        weiyongjun1@...wei.com, linux-pci@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v4 3/7] phy: qcom-qmp: Fix phy pipe clock name



On 07/21/2017 05:06 PM, Varadarajan Narayanan wrote:
> Presently, the phy pipe clock's name is assumed to be either
> usb3_phy_pipe_clk_src or pcie_XX_pipe_clk_src (where XX is the
> phy lane's number). However, this will not work if an SoC has
> more than one instance of the phy. Hence, instead of assuming
> the name of the clock, fetch it from the DT.
>
> Signed-off-by: Varadarajan Narayanan <varada@...eaurora.org>
> ---
>   drivers/phy/qualcomm/phy-qcom-qmp.c | 45 +++++++++++++++++++++++--------------
>   1 file changed, 28 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
> index 78ca628..b046866 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
> @@ -925,20 +925,13 @@ static int qcom_qmp_phy_clk_init(struct device *dev)
>    *    clk  |   +-------+   |                   +-----+
>    *         +---------------+
>    */
> -static int phy_pipe_clk_register(struct qcom_qmp *qmp, int id)
> +static int phy_pipe_clk_register(struct qcom_qmp *qmp, const char *clk_name)
>   {
> -	char name[24];
>   	struct clk_fixed_rate *fixed;
>   	struct clk_init_data init = { };
>   
> -	switch (qmp->cfg->type) {
> -	case PHY_TYPE_USB3:
> -		snprintf(name, sizeof(name), "usb3_phy_pipe_clk_src");
> -		break;
> -	case PHY_TYPE_PCIE:
> -		snprintf(name, sizeof(name), "pcie_%d_pipe_clk_src", id);
> -		break;
> -	default:
> +	if ((qmp->cfg->type != PHY_TYPE_USB3) &&
> +	    (qmp->cfg->type != PHY_TYPE_PCIE)) {
>   		/* not all phys register pipe clocks, so return success */
>   		return 0;
>   	}
> @@ -947,7 +940,7 @@ static int phy_pipe_clk_register(struct qcom_qmp *qmp, int id)
>   	if (!fixed)
>   		return -ENOMEM;
>   
> -	init.name = name;
> +	init.name = clk_name;
>   	init.ops = &clk_fixed_rate_ops;
>   
>   	/* controllers using QMP phys use 125MHz pipe clock interface */
> @@ -1110,6 +1103,8 @@ static int qcom_qmp_phy_probe(struct platform_device *pdev)
>   
>   	id = 0;
>   	for_each_available_child_of_node(dev->of_node, child) {
> +		const char *clk_name;
> +
>   		/* Create per-lane phy */
>   		ret = qcom_qmp_phy_create(dev, child, id);
>   		if (ret) {
> @@ -1119,15 +1114,31 @@ static int qcom_qmp_phy_probe(struct platform_device *pdev)
>   		}
>   
>   		/*
> -		 * Register the pipe clock provided by phy.
> -		 * See function description to see details of this pipe clock.
> +		 * This property is mandatory only for PCIe/USB phys.
> +		 * For other phy types don't return failure.
>   		 */
> -		ret = phy_pipe_clk_register(qmp, id);
> -		if (ret) {
> -			dev_err(qmp->dev,
> -				"failed to register pipe clock source\n");
> +		ret = of_property_read_string(child, "clock-output-names",
> +							&clk_name);
> +		if (ret && (qmp->cfg->type == PHY_TYPE_PCIE ||
> +			    qmp->cfg->type == PHY_TYPE_USB3)) {

Let's not check the phy type twice. Once here and once again in the
phy_pipe_clk_register().
May be we can move this property read in phy_pipe_clk_registe() itself.
That way you can avoid passing the clk_name also. WDUT?

Regards
Vivek
> +			dev_err(dev,
> +				"failed to get clock-output-names for lane%d phy, %d\n",
> +				id, ret);
>   			return ret;
>   		}
> +
> +		if (!ret) {
> +			/*
> +			 * Register the pipe clock provided by phy. See function
> +			 * description to see details of this pipe clock.
> +			 */
> +			ret = phy_pipe_clk_register(qmp, clk_name);
> +			if (ret) {
> +				dev_err(qmp->dev,
> +					"failed to register pipe clock source\n");
> +				return ret;
> +			}
> +		}
>   		id++;
>   	}
>   

-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project