linux-kernel - Re: [PATCH] usb: dts: fix the issue that usb is not detected on ls1088ardb

Open Source and information security mailing list archives

Message-ID: <20170726022414.GH29754@dragon>
Date:   Wed, 26 Jul 2017 10:24:16 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     yinbo.zhu@....com
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, Mihai Bantea <mihai.bantea@....com>,
        Horia Geantă <horia.geanta@....com>,
        Marc Zyngier <marc.zyngier@....com>,
        Liu Gang <Gang.Liu@....com>,
        open list <linux-kernel@...r.kernel.org>,
        Scott Wood <oss@...error.net>,
        Tang Yuantian <Yuantian.Tang@....com>,
        York Sun <york.sun@....com>,
        "moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] usb: dts: fix the issue that usb is not detected on
 ls1088ardb

On Thu, Jul 20, 2017 at 10:38:26AM +0800, yinbo.zhu@....com wrote:
> From: "yinbo.zhu" <yinbo.zhu@....com>
> 
> Signed-off-by: yinbo.zhu <yinbo.zhu@....com>

The subject should be prefixed like 'arm64: dts: ls1088a: ...'.  And
the current subject is confusing.  You are adding USB support rather
than fixing something.

Also empty commit log is not really good.

> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts |  8 ++++++++
>  arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi    | 18 ++++++++++++++++++
>  2 files changed, 26 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> index e9276a5..d5c3d96 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> @@ -149,6 +149,14 @@
>  	status = "okay";
>  };
>  
> +&usb0 {
> +	status = "okay";
> +};
> +
> +&usb1 {
> +	status = "okay";
> +};
> +
>  &emdio1 {
>  	/* Freescale F104 PHY1 */
>  	mdio1_phy1: emdio1_phy@1 {

What tree is your patch generated against?  I do not see this 'emdio1'
device in my tree.

Remember to sort the node alphabetically in label name when adding new
labelled nodes.

> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> index 3a3be87..65b3059 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> @@ -566,6 +566,24 @@
>  			fsl,qspi-has-second-chip;
>  		};
>  
> +		usb0: usb3@...0000 {
> +			compatible = "snps,dwc3";
> +			reg = <0x0 0x3100000 0x0 0x10000>;
> +			interrupts = <0 80 0x4>; /* Level high type */

Use IRQ_TYPE_LEVEL_HIGH, so that you can save the comment here.

> +			dr_mode = "host";
> +			configure-gfladj;

What is this property?

Shawn

> +			snps,dis_rxdet_inp3_quirk;
> +		};
> +
> +		usb1: usb3@...0000 {
> +			compatible = "snps,dwc3";
> +			reg = <0x0 0x3110000 0x0 0x10000>;
> +			interrupts = <0 81 0x4>; /* Level high type */
> +			dr_mode = "host";
> +			configure-gfladj;
> +			snps,dis_rxdet_inp3_quirk;
> +		};
> +
>  		pcie@...0000 {
>  			compatible = "fsl,ls2088a-pcie", "fsl,ls1088a-pcie",
>  				     "snps,dw-pcie";
> -- 
> 2.1.0.27.g96db324
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives