linux-kernel - Re: [PATCH 2/3] ACPI/DRM: rework ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <14179844.x9VpZbiLx4@aspire.rjw.lan>
Date:   Wed, 26 Jul 2017 20:23:25 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     dri-devel@...ts.freedesktop.org, Len Brown <lenb@...nel.org>,
        Lucas Stach <l.stach@...gutronix.de>,
        Russell King <linux+etnaviv@...linux.org.uk>,
        Christian Gmeiner <christian.gmeiner@...il.com>,
        David Airlie <airlied@...ux.ie>,
        Patrik Jakobsson <patrik.r.jakobsson@...il.com>,
        Daniel Vetter <daniel.vetter@...el.com>,
        Jani Nikula <jani.nikula@...ux.intel.com>,
        Ben Skeggs <bskeggs@...hat.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Jens Frederich <jfrederich@...il.com>,
        Daniel Drake <dsd@...top.org>,
        Jon Nettleton <jon.nettleton@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
        etnaviv@...ts.freedesktop.org, intel-gfx@...ts.freedesktop.org,
        nouveau@...ts.freedesktop.org, platform-driver-x86@...r.kernel.org,
        devel@...verdev.osuosl.org
Subject: Re: [PATCH 2/3] ACPI/DRM: rework ACPI_VIDEO Kconfig dependencies

On Wednesday, July 26, 2017 03:53:11 PM Arnd Bergmann wrote:
> ACPI_VIDEO keeps causing problems with circular Kconfig dependencies,
> as it depends on a couple of other symbols, and it gets selected by
> drivers that may end up being depending on others.
> 
> This is an attempt to simplify this by changing all drivers that
> currently 'select ACPI_VIDEO' to use 'depends on'. This by itself
> simplifies the dependency lists for the other drivers. We make
> ACPI_VIDEO 'default y' to avoid having it turned off for 'make
> oldconfig' users. This should again be fine as x86 users will
> normally want this enabled and the option is not available elsewhere.
> 
> I'm moving the 'select BACKLIGHT_CLASS_DEVICE/BACKLIGHT_LCD_SUPPORT'
> into ACPI_VIDEO as a further simplification, those were already
> selected by anything that selected ACPI_VIDEO before.
> 
> Changing the INPUT dependency in ACPI_CMPC is necessary to avoid a
> circular dependency with X86_PLATFORM_DEVICES/NOUVEAU.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/acpi/Kconfig            |  5 ++++-
>  drivers/gpu/drm/gma500/Kconfig  |  6 +-----
>  drivers/gpu/drm/i915/Kconfig    |  7 +------
>  drivers/gpu/drm/nouveau/Kconfig | 10 ++--------
>  drivers/platform/x86/Kconfig    |  6 ++----
>  5 files changed, 10 insertions(+), 24 deletions(-)
> 
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index 1ce52f84dc23..a8f5a40e2914 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -182,9 +182,12 @@ config ACPI_BUTTON
>  
>  config ACPI_VIDEO
>  	tristate "Video"
> -	depends on X86 && BACKLIGHT_CLASS_DEVICE
> +	depends on X86
>  	depends on INPUT
>  	select THERMAL
> +	select BACKLIGHT_CLASS_DEVICE
> +	select BACKLIGHT_LCD_SUPPORT
> +	default y
>  	help
>  	  This driver implements the ACPI Extensions For Display Adapters
>  	  for integrated graphics devices on motherboard, as specified in

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

for the ACPI_VIDEO changes.

Thanks,
Rafael