linux-kernel - Re: [Intel-gfx] [PATCH 0/3] Kconfig dependencies: acpi-video, backlight and thermal

Open Source and information security mailing list archives

Message-ID: <87tw1sj151.fsf@nikula.org>
Date:   Mon, 31 Jul 2017 14:28:58 +0300
From:   Jani Nikula <jani.nikula@...ux.intel.com>
To:     Daniel Vetter <daniel@...ll.ch>, Arnd Bergmann <arnd@...db.de>
Cc:     devel@...verdev.osuosl.org, Daniel Drake <dsd@...top.org>,
        Jens Frederich <jfrederich@...il.com>,
        nouveau@...ts.freedesktop.org,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        etnaviv@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        platform-driver-x86@...r.kernel.org, linux-acpi@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Ben Skeggs <bskeggs@...hat.com>,
        Russell King <linux+etnaviv@...linux.org.uk>,
        Daniel Vetter <daniel.vetter@...el.com>,
        Andy Shevchenko <andy@...radead.org>,
        intel-gfx@...ts.freedesktop.org,
        Darren Hart <dvhart@...radead.org>,
        linux-kernel@...r.kernel.org, Len Brown <lenb@...nel.org>
Subject: Re: [Intel-gfx] [PATCH 0/3] Kconfig dependencies: acpi-video, backlight and thermal

On Wed, 26 Jul 2017, Daniel Vetter <daniel@...ll.ch> wrote:
> On Wed, Jul 26, 2017 at 03:53:09PM +0200, Arnd Bergmann wrote:
>> Hi everyone,
>> 
>> It took me a while to figure this out properly, as I kept getting
>> circular or missing dependencies with video drivers.
>> 
>> This set of three patches should simplify the situation a bit,
>> mostly by cleaning up the dependencies around CONFIG_ACPI_VIDEO.
>> With all three patches applied, I no longer run into those related
>> warnings. If everyone agrees on the general direction, I hope
>> we can merge all three through the DRM tree.
>> 
>> I originally had another larger patch in the series to replace all
>> of the 'select BACKLIGHT_LCD_SUPPORT; select BACKLIGHT_CLASS_DEVICE'
>> statements with 'depends on LCD_CLASS_DEVICE', that would clean
>> it up some more, but it is also a more invasive change that we
>> can do separately at some point.
>
> Looks reasonable, but I think it'd be good to get Jani Nikula's explicit
> ack on this, since he dugg around a lot in this area. And he's on vacation
> this week.

I didn't dig through all the details, but looks good to me and
definitely an improvement in drm Kconfigs.

Acked-by: Jani Nikula <jani.nikula@...el.com>

> -Daniel
>
>> 
>>        Arnd
>> 
>> Arnd Bergmann (3):
>>   backlight: always select BACKLIGHT_LCD_SUPPORT for
>>     BACKLIGHT_CLASS_DEVICE
>>   ACPI/DRM: rework ACPI_VIDEO Kconfig dependencies
>>   drm/etnaviv: add thermal dependency
>> 
>>  drivers/acpi/Kconfig              |  7 +++++--
>>  drivers/gpu/drm/etnaviv/Kconfig   |  1 +
>>  drivers/gpu/drm/gma500/Kconfig    |  5 +----
>>  drivers/gpu/drm/i915/Kconfig      |  7 +------
>>  drivers/gpu/drm/nouveau/Kconfig   | 10 ++--------
>>  drivers/platform/x86/Kconfig      |  9 ++++-----
>>  drivers/staging/olpc_dcon/Kconfig |  1 +
>>  7 files changed, 15 insertions(+), 25 deletions(-)
>> 
>> To: dri-devel@...ts.freedesktop.org
>> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
>> Cc: Len Brown <lenb@...nel.org>
>> Cc: Lucas Stach <l.stach@...gutronix.de>
>> Cc: Russell King <linux+etnaviv@...linux.org.uk>
>> Cc: Christian Gmeiner <christian.gmeiner@...il.com>
>> Cc: David Airlie <airlied@...ux.ie>
>> Cc: Patrik Jakobsson <patrik.r.jakobsson@...il.com>
>> Cc: Daniel Vetter <daniel.vetter@...el.com>
>> Cc: Jani Nikula <jani.nikula@...ux.intel.com>
>> Cc: Ben Skeggs <bskeggs@...hat.com>
>> Cc: Darren Hart <dvhart@...radead.org>
>> Cc: Andy Shevchenko <andy@...radead.org>
>> Cc: Jens Frederich <jfrederich@...il.com>
>> Cc: Daniel Drake <dsd@...top.org>
>> Cc: Jon Nettleton <jon.nettleton@...il.com>
>> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> Cc: linux-acpi@...r.kernel.org
>> Cc: linux-kernel@...r.kernel.org
>> Cc: etnaviv@...ts.freedesktop.org
>> Cc: intel-gfx@...ts.freedesktop.org
>> Cc: nouveau@...ts.freedesktop.org
>> Cc: platform-driver-x86@...r.kernel.org
>> Cc: devel@...verdev.osuosl.org
>> 
>> -- 
>> 2.9.0
>> 
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@...ts.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives