linux-kernel - Re: [PATCH v3 2/2] dt-bindings: add documentation for rk3126 clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1528313.SDTh7a5k6t@diego>
Date:   Mon, 31 Jul 2017 13:24:27 +0200
From:   Heiko Stübner <heiko@...ech.de>
To:     Elaine Zhang <zhangqing@...k-chips.com>
Cc:     mturquette@...libre.com, sboyd@...eaurora.org,
        linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
        robh+dt@...nel.org, mark.rutland@....com,
        devicetree@...r.kernel.org, xxx@...k-chips.com, xf@...k-chips.com,
        huangtao@...k-chips.com, cl@...k-chips.com
Subject: Re: [PATCH v3 2/2] dt-bindings: add documentation for rk3126 clock

Hi Elaine,

Am Montag, 31. Juli 2017, 18:42:08 CEST schrieb Elaine Zhang:
> This add bindings documentation for rk3126 SoCs.
> 
> Signed-off-by: Elaine Zhang <zhangqing@...k-chips.com>

thanks for noticing that the binding doc was missing, I meant to
write a response about that but didn't find the time yet.

> ---
>  Documentation/devicetree/bindings/clock/rockchip,rk3128-cru.txt | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/rockchip,rk3128-cru.txt
> b/Documentation/devicetree/bindings/clock/rockchip,rk3128-cru.txt index
> 455a9a00a623..25098fa8595f 100644
> --- a/Documentation/devicetree/bindings/clock/rockchip,rk3128-cru.txt
> +++ b/Documentation/devicetree/bindings/clock/rockchip,rk3128-cru.txt
> @@ -1,12 +1,12 @@
> -* Rockchip RK3128 Clock and Reset Unit
> +* Rockchip RK3128/RK3126 Clock and Reset Unit
> 
> -The RK3128 clock controller generates and supplies clock to various
> +The RK3128/RK3126 clock controller generates and supplies clock to various
>  controllers within the SoC and also implements a reset controller for SoC
>  peripherals.
> 
>  Required Properties:
> 
> -- compatible: should be "rockchip,rk3128-cru"
> +- compatible: should be "rockchip,rk3128-cru", "rockchip,rk3126-cru"

- compatible: should be one of "rockchip,rk3128-cru" or "rockchip,rk3126-cru".


Heiko


>  - reg: physical base address of the controller and length of memory mapped
>    region.
>  - #clock-cells: should be 1.