linux-kernel - Re: [PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1632667.Vgem7HtdXu@aspire.rjw.lan>
Date:   Wed, 26 Jul 2017 20:57:03 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Borislav Petkov <bp@...e.de>
Cc:     Loc Ho <lho@....com>, msalter@...hat.com, rafael@...nel.org,
        tbaicar@...eaurora.org, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        patches@....com, "Luck, Tony" <tony.luck@...el.com>
Subject: Re: [PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

On Sunday, July 23, 2017 12:01:10 AM Rafael J. Wysocki wrote:
> On Saturday, July 22, 2017 07:59:54 AM Borislav Petkov wrote:
> > On Fri, Jul 21, 2017 at 11:24:37AM -0700, Loc Ho wrote:
> > > X-Gene platforms describe multiple GHES error sources with the same hardware
> > > error notification type (external interrupt) and interrupt number.
> > > Change the GHES interrupt request to support sharing the same IRQ.
> > > 
> > > Co-authored-by: Tuan Phan <tphan@....com>
> > > Signed-off-by: Loc Ho <lho@....com>
> > > ---
> > >  drivers/acpi/apei/ghes.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> > > index d661d45..eed09fc 100644
> > > --- a/drivers/acpi/apei/ghes.c
> > > +++ b/drivers/acpi/apei/ghes.c
> > > @@ -1157,7 +1157,8 @@ static int ghes_probe(struct platform_device *ghes_dev)
> > >  			       generic->header.source_id);
> > >  			goto err_edac_unreg;
> > >  		}
> > > -		rc = request_irq(ghes->irq, ghes_irq_func, 0, "GHES IRQ", ghes);
> > > +		rc = request_irq(ghes->irq, ghes_irq_func, IRQF_SHARED,
> > > +				 "GHES IRQ", ghes);
> > >  		if (rc) {
> > >  			pr_err(GHES_PFX "Failed to register IRQ for generic hardware error source: %d\n",
> > >  			       generic->header.source_id);
> > 
> > Acked-by: Borislav Petkov <bp@...e.de>
> 
> OK
> 
> Should I apply this or will Tony do that?

So am I suppsed to drop this?