linux-kernel - Re: [PATCH v7 2/3] PCI: Enable PCIe Relaxed Ordering if supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <MWHPR12MB16007782C422082A92F4765DC8B90@MWHPR12MB1600.namprd12.prod.outlook.com>
Date:   Wed, 26 Jul 2017 19:05:49 +0000
From:   Casey Leedom <leedom@...lsio.com>
To:     Alexander Duyck <alexander.duyck@...il.com>
CC:     Netdev <netdev@...r.kernel.org>,
        Bjorn Helgaas <helgaas@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "David.Laight@...lab.com" <David.Laight@...lab.com>,
        "ashok.raj@...el.com" <ashok.raj@...el.com>,
        "Alex Williamson" <alex.williamson@...hat.com>,
        "l.stach@...gutronix.de" <l.stach@...gutronix.de>,
        "Suravee.Suthikulpanit@....com" <Suravee.Suthikulpanit@....com>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "will.deacon@....com" <will.deacon@....com>,
        Sinan Kaya <okaya@...eaurora.org>,
        "robin.murphy@....com" <robin.murphy@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Ganesh GR <ganeshgr@...lsio.com>,
        "asit.k.mallick@...el.com" <asit.k.mallick@...el.com>,
        "jeffrey.t.kirsher@...el.com" <jeffrey.t.kirsher@...el.com>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "gabriele.paoloni@...wei.com" <gabriele.paoloni@...wei.com>,
        Michael Werner <werner@...lsio.com>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "patrick.j.cramer@...el.com" <patrick.j.cramer@...el.com>,
        Ding Tianhong <dingtianhong@...wei.com>,
        "linuxarm@...wei.com" <linuxarm@...wei.com>,
        "amira@...lanox.com" <amira@...lanox.com>,
        "Bob.Shaw@....com" <Bob.Shaw@....com>
Subject: Re: [PATCH v7 2/3] PCI: Enable PCIe Relaxed Ordering if supported

| From: Alexander Duyck <alexander.duyck@...il.com>
| Sent: Wednesday, July 26, 2017 11:44 AM
| 
| On Jul 26, 2017 11:26 AM, "Casey Leedom" <leedom@...lsio.com> wrote:
| |
| |     I think that the patch will need to be extended to modify
| |     drivers/pci.c/iov.c:sriov_enable() to explicitly turn off
| |     Relaxed Ordering Enable if the Root Complex is marked
|     for no RO TLPs.
| 
| I'm not sure that would be an issue. Wouldn't most VFs inherit the PF's settings?

Ah yes, you're right.  This is covered in section 3.5.4 of the Single Root I/O
Virtualization and Sharing Specification, Revision 1.0 (September 11, 2007),
governing the PCIe Capability Device Control register.  It states that the VF
version of that register shall follow the setting of the corresponding PF.

So we should enhance the cxgb4vf/sge.c:t4vf_sge_alloc_rxq() in the same
way we did for the cxgb4 driver, but that's not critical since the Relaxed
Ordering Enable supersedes the internal chip's desire to use the Relaxed
Ordering Attribute.

Ding, send me a note if you'd like me to work that up for you.

| Also I thought most of the VF configuration space is read only.

Yes, but not all of it.  And when a VF is exported to a Virtual Machine,
then the Hypervisor captures and interprets all accesses to the VF's
PCIe Configuration Space from the VM.

Thanks again for reminding me of the subtle aspect of the SR_IOV
specification that I forgot.

Casey