linux-kernel - Re: [PATCH v1 4/6] ASoC: codecs: msm8916-wcd-analog: set default micbias voltage to 1.8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Jul 2017 15:45:08 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     Banajit Goswami <bgoswami@...eaurora.org>,
        alsa-devel@...a-project.org, Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Patrick Lai <plai@...eaurora.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 4/6] ASoC: codecs: msm8916-wcd-analog: set default
 micbias voltage to 1.8



On 28/07/17 15:01, Mark Brown wrote:
> On Fri, Jul 28, 2017 at 02:54:59PM +0100, Srinivas Kandagatla wrote:
>> On 28/07/17 14:40, Mark Brown wrote:
>>> On Wed, Jul 26, 2017 at 02:35:10AM +0200, srinivas.kandagatla@...aro.org wrote:
>>>> From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> 
>>>> This patch sets the default internal micbias voltage to 1.8v. This
>>>> default value is required for mbhc buttons to work. Also adds dt
>>>> bindings to allow the board level file to specify the required default
>>>> micbias value.
> 
>>> What was the default previously?
> 
>> This was set to 2.7v previously for special headsets which have high
>> impedance.
> 
> So obviously this will break existing users.  That's not OK.

This would not break any exiting users, as this part is applicable for 
only headset detect usecase. I will try to address this in ("PATCH 5/6 
ASoC: codecs: msm8916-wcd-analog: add MBHC support") patch.

The default voltage for most common usecase should be set to 1.8v anyway.