linux-kernel - Re: [PATCH 08/14] ipmi: use atomic_dec_not

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <29e3f415-bdf3-05b0-e443-af84155022c1@acm.org>
Date:   Fri, 28 Jul 2017 09:44:58 -0500
From:   Corey Minyard <minyard@....org>
To:     Fabian Frederick <fabf@...net.be>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org,
        openipmi-developer@...ts.sourceforge.net
Subject: Re: [PATCH 08/14] ipmi: use atomic_dec_not_zero()

On 07/28/2017 09:27 AM, Corey Minyard wrote:
> I missed this until now, and I see it hasn't been applied yet.  It's 
> queued for the next release.
>

Well, never mind, I see the main update didn't go in.

-corey

> Thanks,
>
> -corey
>
> On 01/30/2017 12:47 PM, Fabian Frederick wrote:
>> instead of atomic_add_unless(value, -1, 0)
>>
>> Signed-off-by: Fabian Frederick <fabf@...net.be>
>> ---
>>   drivers/char/ipmi/ipmi_msghandler.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/char/ipmi/ipmi_msghandler.c 
>> b/drivers/char/ipmi/ipmi_msghandler.c
>> index 9f69995..961d677 100644
>> --- a/drivers/char/ipmi/ipmi_msghandler.c
>> +++ b/drivers/char/ipmi/ipmi_msghandler.c
>> @@ -3851,7 +3851,7 @@ static void handle_new_recv_msgs(ipmi_smi_t intf)
>>        * If the pretimout count is non-zero, decrement one from it and
>>        * deliver pretimeouts to all the users.
>>        */
>> -    if (atomic_add_unless(&intf->watchdog_pretimeouts_to_deliver, 
>> -1, 0)) {
>> +    if (atomic_dec_not_zero(&intf->watchdog_pretimeouts_to_deliver)) {
>>           ipmi_user_t user;
>>             rcu_read_lock();
>
>