linux-kernel - Re: [PATCH] drm/amd/powerplay: rv: Use designated initializers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jJ8uJTDHVWv9qwULRmoF6n5tHK=a2WWoe2CMGfmD8Wc4g@mail.gmail.com>
Date:   Fri, 28 Jul 2017 10:15:43 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Alex Deucher <alexdeucher@...il.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        David Airlie <airlied@...ux.ie>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        Alex Deucher <alexander.deucher@....com>,
        Rex Zhu <Rex.Zhu@....com>,
        Christian König <christian.koenig@....com>,
        Hawking Zhang <Hawking.Zhang@....com>
Subject: Re: [PATCH] drm/amd/powerplay: rv: Use designated initializers

On Thu, Jul 27, 2017 at 6:43 PM, Alex Deucher <alexdeucher@...il.com> wrote:
> On Tue, Jul 25, 2017 at 5:47 PM, Kees Cook <keescook@...omium.org> wrote:
>> As done for vega10 in commit 3ddd396f6b57 ("drm/amd/powerplay: Use
>> designated initializers") mark other tableFunction entries with designated
>> initializers. The randstruct plugin requires designated initializers for
>> structures that are entirely function pointers.
>>
>> Cc: Rex Zhu <Rex.Zhu@....com>
>> Cc: Hawking Zhang <Hawking.Zhang@....com>
>> Cc: Alex Deucher <alexander.deucher@....com>
>> Signed-off-by: Kees Cook <keescook@...omium.org>
>> ---
>> If I can get an Ack for this, I'll carry it in the gcc-plugins tree, unless
>> you think this is worth landing for v4.13, in which case, please take it
>> now. :)
>>
>
> Acked-by: Alex Deucher <alexander.deucher@....com>
>
> I'm happy to take this through my tree if that is ok with you.

Since the randstruct patch depends on this fix, it's likely best to go
through my tree unless you can get this into v4.13. (Since then when
the randstruct patch lands in v4.14, it'll already be there.) I'm fine
either way.

Thanks!

-Kees

-- 
Kees Cook
Pixel Security