linux-kernel - RE: [PATCH] drm/amd/powerplay: rv: Use designated initializers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BN6PR12MB1652FB3CC2DA7D3DF9C5D809F7BF0@BN6PR12MB1652.namprd12.prod.outlook.com>
Date:   Fri, 28 Jul 2017 17:26:57 +0000
From:   "Deucher, Alexander" <Alexander.Deucher@....com>
To:     'Kees Cook' <keescook@...omium.org>,
        Alex Deucher <alexdeucher@...il.com>
CC:     LKML <linux-kernel@...r.kernel.org>,
        David Airlie <airlied@...ux.ie>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>, "Zhu, Rex" <Rex.Zhu@....com>,
        "Koenig, Christian" <Christian.Koenig@....com>,
        "Zhang, Hawking" <Hawking.Zhang@....com>
Subject: RE: [PATCH] drm/amd/powerplay: rv: Use designated initializers

> -----Original Message-----
> From: keescook@...gle.com [mailto:keescook@...gle.com] On Behalf Of
> Kees Cook
> Sent: Friday, July 28, 2017 1:16 PM
> To: Alex Deucher
> Cc: LKML; David Airlie; amd-gfx list; Maling list - DRI developers; Deucher,
> Alexander; Zhu, Rex; Koenig, Christian; Zhang, Hawking
> Subject: Re: [PATCH] drm/amd/powerplay: rv: Use designated initializers
> 
> On Thu, Jul 27, 2017 at 6:43 PM, Alex Deucher <alexdeucher@...il.com>
> wrote:
> > On Tue, Jul 25, 2017 at 5:47 PM, Kees Cook <keescook@...omium.org>
> wrote:
> >> As done for vega10 in commit 3ddd396f6b57 ("drm/amd/powerplay: Use
> >> designated initializers") mark other tableFunction entries with designated
> >> initializers. The randstruct plugin requires designated initializers for
> >> structures that are entirely function pointers.
> >>
> >> Cc: Rex Zhu <Rex.Zhu@....com>
> >> Cc: Hawking Zhang <Hawking.Zhang@....com>
> >> Cc: Alex Deucher <alexander.deucher@....com>
> >> Signed-off-by: Kees Cook <keescook@...omium.org>
> >> ---
> >> If I can get an Ack for this, I'll carry it in the gcc-plugins tree, unless
> >> you think this is worth landing for v4.13, in which case, please take it
> >> now. :)
> >>
> >
> > Acked-by: Alex Deucher <alexander.deucher@....com>
> >
> > I'm happy to take this through my tree if that is ok with you.
> 
> Since the randstruct patch depends on this fix, it's likely best to go
> through my tree unless you can get this into v4.13. (Since then when
> the randstruct patch lands in v4.14, it'll already be there.) I'm fine
> either way.

Go ahead and take it through your tree.  Thanks!

Alex

> 
> Thanks!
> 
> -Kees
> 
> --
> Kees Cook
> Pixel Security