linux-kernel - Re: [PATCH 0/3] selftests: sync test conversion to TAP13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Jul 2017 15:25:40 -0300
From:   Gustavo Padovan <gustavo.padovan@...labora.com>
To:     Shuah Khan <shuahkh@....samsung.com>, shuah@...nel.org,
        emilio.lopez@...labora.co.uk, mpe@...erman.id.au
Cc:     linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] selftests: sync test conversion to TAP13

Hi Shuah,

Thank you for your patches.

On Mon, 2017-07-24 at 15:07 -0600, Shuah Khan wrote:
> This patch series includes patches to convert sync test to use TAP13
> ksft framework. In addition, fix to sync test to differentiate
> between
> unsupported feature and access error when a non-root user runs it.
> 
> Updated kfst framework to return counters for sync test to use to
> print
> the final pass or fail summary message. Updated ksft+print_cnts() to
> print counters to summarize the test results.
> 
> Shuah Khan (3):
>   selftests: sync: differentiate between sync unsupported and access
>     errors
>   selftests: kselftest framework: add API to return pass/fail/*
> counts
>   selftests: sync: convert to use TAP13 ksft framework
> 
>  tools/testing/selftests/kselftest.h      | 10 +++++
>  tools/testing/selftests/sync/sync_test.c | 71 +++++++++++++++++++++-
> ----------
>  tools/testing/selftests/sync/synctest.h  |  3 +-
>  3 files changed, 58 insertions(+), 26 deletions(-)

All looks good to me, so for the 3 patches:
Reviewed-by: Gustavo Padovan <gustavo.padovan@...labora.com>

	Gustavo

-- 
Gustavo Padovan
Collabora Ltd.