linux-kernel - Re: [PATCH 0/3] selftests: sync test conversion to TAP13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6027a4dd-82f8-6886-7fc6-a9c1553c5e34@kernel.org>
Date:   Fri, 28 Jul 2017 13:12:47 -0600
From:   Shuah Khan <shuah@...nel.org>
To:     Gustavo Padovan <gustavo.padovan@...labora.com>,
        Shuah Khan <shuahkh@....samsung.com>,
        emilio.lopez@...labora.co.uk, mpe@...erman.id.au
Cc:     linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        Shuah Khan <shuah@...nel.org>,
        Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH 0/3] selftests: sync test conversion to TAP13

On 07/28/2017 12:25 PM, Gustavo Padovan wrote:
> Hi Shuah,
> 
> Thank you for your patches.
> 
> On Mon, 2017-07-24 at 15:07 -0600, Shuah Khan wrote:
>> This patch series includes patches to convert sync test to use TAP13
>> ksft framework. In addition, fix to sync test to differentiate
>> between
>> unsupported feature and access error when a non-root user runs it.
>>
>> Updated kfst framework to return counters for sync test to use to
>> print
>> the final pass or fail summary message. Updated ksft+print_cnts() to
>> print counters to summarize the test results.
>>
>> Shuah Khan (3):
>>   selftests: sync: differentiate between sync unsupported and access
>>     errors
>>   selftests: kselftest framework: add API to return pass/fail/*
>> counts
>>   selftests: sync: convert to use TAP13 ksft framework
>>
>>  tools/testing/selftests/kselftest.h      | 10 +++++
>>  tools/testing/selftests/sync/sync_test.c | 71 +++++++++++++++++++++-
>> ----------
>>  tools/testing/selftests/sync/synctest.h  |  3 +-
>>  3 files changed, 58 insertions(+), 26 deletions(-)
> 
> All looks good to me, so for the 3 patches:
> Reviewed-by: Gustavo Padovan <gustavo.padovan@...labora.com>
> 
> 	Gustavo
> 

Thanks Gustavo. I will get them in to linux-ksefltest next for 4.14-rc1
with your Reviwed-by.

-- Shuah