linux-kernel - Re: [RESEND PATCH 2/6] ipc: mqueue: Replace timespec with timespec64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Jul 2017 13:44:24 -0700
From:   Deepa Dinamani <deepa.kernel@...il.com>
To:     Paul Moore <paul@...l-moore.com>
Cc:     Alexander Viro <viro@...iv.linux.org.uk>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux FS-devel Mailing List <linux-fsdevel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        y2038 Mailman List <y2038@...ts.linaro.org>,
        Richard Guy Briggs <rgb@...hat.com>
Subject: Re: [RESEND PATCH 2/6] ipc: mqueue: Replace timespec with timespec64

On Fri, Jul 28, 2017 at 1:15 PM, Paul Moore <paul@...l-moore.com> wrote:
> On Fri, Jul 28, 2017 at 2:52 PM, Deepa Dinamani <deepa.kernel@...il.com> wrote:
>> struct timespec is not y2038 safe. Replace
>> all uses of timespec by y2038 safe struct timespec64.
>>
>> Even though timespec is used here to represent timeouts,
>> replace these with timespec64 so that it facilitates
>> in verification by creating a y2038 safe kernel image
>> that is free of timespec.
>>
>> The syscall interfaces themselves are not changed as part
>> of the patch. They will be part of a different series.
>>
>> Signed-off-by: Deepa Dinamani <deepa.kernel@...il.com>
>> Cc: Paul Moore <paul@...l-moore.com>
>> Cc: Richard Guy Briggs <rgb@...hat.com>
>> ---
>>  include/linux/audit.h |  6 +++---
>>  ipc/mqueue.c          | 28 ++++++++++++++--------------
>>  kernel/audit.h        |  2 +-
>>  kernel/auditsc.c      | 12 ++++++------
>>  4 files changed, 24 insertions(+), 24 deletions(-)
>
> Something is wrong here ... I already merged your audit y2038 fixes,
> you can see them in Linus' tree right now.

This is the audit record for ipc mqueue side of things.
The other patch does not touch this:

-Deepa

On Fri, Jul 28, 2017 at 1:15 PM, Paul Moore <paul@...l-moore.com> wrote:
> On Fri, Jul 28, 2017 at 2:52 PM, Deepa Dinamani <deepa.kernel@...il.com> wrote:
>> struct timespec is not y2038 safe. Replace
>> all uses of timespec by y2038 safe struct timespec64.
>>
>> Even though timespec is used here to represent timeouts,
>> replace these with timespec64 so that it facilitates
>> in verification by creating a y2038 safe kernel image
>> that is free of timespec.
>>
>> The syscall interfaces themselves are not changed as part
>> of the patch. They will be part of a different series.
>>
>> Signed-off-by: Deepa Dinamani <deepa.kernel@...il.com>
>> Cc: Paul Moore <paul@...l-moore.com>
>> Cc: Richard Guy Briggs <rgb@...hat.com>
>> ---
>>  include/linux/audit.h |  6 +++---
>>  ipc/mqueue.c          | 28 ++++++++++++++--------------
>>  kernel/audit.h        |  2 +-
>>  kernel/auditsc.c      | 12 ++++++------
>>  4 files changed, 24 insertions(+), 24 deletions(-)
>
> Something is wrong here ... I already merged your audit y2038 fixes,
> you can see them in Linus' tree right now.
>
> --
> paul moore
> www.paul-moore.com