linux-kernel - Re: [PATCH] rtc: rtc-max8925: remove redundant check on ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170730150604.d7lhvwx7c4v4knsw@piout.net>
Date:   Sun, 30 Jul 2017 17:06:04 +0200
From:   Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Alessandro Zummo <a.zummo@...ertech.it>, linux-rtc@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: rtc-max8925: remove redundant check on ret

On 07/06/2017 at 16:26:15 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The check on ret < 0 is redundant as the goto destination is the
> next statment.  Remove this redudant check and goto.
> 
> Detected by CoverityScan, CID#1268785 ("Identical code for different
> branches")
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/rtc/rtc-max8925.c | 2 --
>  1 file changed, 2 deletions(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com