linux-kernel - Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 31 Jul 2017 15:48:34 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        Grygorii Strashko <grygorii.strashko@...com>,
        William Breathitt Gray <vilhelm.gray@...il.com>,
        Ray Jui <rjui@...adcom.com>,
        Sören Brinkmann <soren.brinkmann@...inx.com>,
        David Cohen <david.a.cohen@...ux.intel.com>,
        Scott Branden <sbranden@...adcom.com>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Alexander Shiyan <shc_work@...l.ru>,
        Michal Simek <michal.simek@...inx.com>,
        Kevin Hilman <khilman@...nel.org>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        Joel Stanley <joel@....id.au>,
        Linux-OMAP <linux-omap@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        patches@...nsource.cirrus.com, Alban Bedel <albeu@...e.fr>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Thor Thayer <thor.thayer@...ux.intel.com>,
        Tien Hock Loh <thloh@...era.com>
Subject: Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h

On Tue, Jul 4, 2017 at 12:06 PM, Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
> On Tue, 2017-07-04 at 12:53 +0900, Masahiro Yamada wrote:
>> Some of include directives in include/linux/gpio/driver.h are
>> unneeded because the header does not need to know the content of
>> struct device, irq_chip, etc.  Just declare they are structures.
>>
>> On the other hand, <linux/irqhandler.h> and <linux/spinlock_types.h>
>> turned out to be necessary for irq_flow_handler_t and spinlock_t,
>> respectively.
>>
>> Each driver should include what it needs without relying on what is
>> implicitly included from <linux/gpio/driver.h>.  This will cut down
>> unnecessary header parsing.
>
> If Linus is okay with the following proposal I would rather go with it,
> i.e. logical split the series to
>
> 1. Fix IRQ related headers inclusion
> 2. Fix pinconf-generic.h inclusion
> 3. Fix OF headers inclusion (btw, of_gpio.h is not enough there?)

That works fine with me, but also one big patch actually, I do not
want to make it too much work to refactor obviously incorrect things.

As soon as we have rough consensus on this and the build robot
are happy I will apply it to GPIO and also pull it into the pinctrl
subsystem.

Yours,
Linus Walleij